Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coupons: small refactor. #4614

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

liorgold2
Copy link
Collaborator

@liorgold2 liorgold2 commented Dec 20, 2023

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.


This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @liorgold2)


crates/cairo-lang-sierra/src/extensions/modules/function_call.rs line 73 at r1 (raw file):

        let [GenericArg::UserFunc(function_id)] = args else {
            return Err(SpecializationError::UnsupportedGenericArg);
        };

Suggestion:

        let function_id = args_as_single_user_func(args)?;

@liorgold2 liorgold2 changed the base branch from pr/liorgold2/lior/coupon-arg/d9d7fbcf to coupons December 20, 2023 11:30
@liorgold2 liorgold2 force-pushed the pr/liorgold2/lior/coupon-arg/c7ed8ab4 branch from d72dcc2 to d5e62be Compare December 20, 2023 11:30
Copy link
Collaborator Author

@liorgold2 liorgold2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @orizi)


crates/cairo-lang-sierra/src/extensions/modules/function_call.rs line 73 at r1 (raw file):

        let [GenericArg::UserFunc(function_id)] = args else {
            return Err(SpecializationError::UnsupportedGenericArg);
        };

Done.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)

commit-id:c7ed8ab4
@liorgold2 liorgold2 force-pushed the pr/liorgold2/lior/coupon-arg/c7ed8ab4 branch from 8d17920 to 0d656bb Compare December 20, 2023 12:47
@liorgold2 liorgold2 enabled auto-merge December 20, 2023 12:47
Copy link
Collaborator Author

@liorgold2 liorgold2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)

@liorgold2 liorgold2 added this pull request to the merge queue Dec 20, 2023
Merged via the queue into coupons with commit eb47e97 Dec 20, 2023
39 checks passed
@orizi orizi deleted the pr/liorgold2/lior/coupon-arg/c7ed8ab4 branch December 21, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants