-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coupons: small refactor. #4614
Coupons: small refactor. #4614
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @liorgold2)
crates/cairo-lang-sierra/src/extensions/modules/function_call.rs
line 73 at r1 (raw file):
let [GenericArg::UserFunc(function_id)] = args else { return Err(SpecializationError::UnsupportedGenericArg); };
Suggestion:
let function_id = args_as_single_user_func(args)?;
d72dcc2
to
d5e62be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-sierra/src/extensions/modules/function_call.rs
line 73 at r1 (raw file):
let [GenericArg::UserFunc(function_id)] = args else { return Err(SpecializationError::UnsupportedGenericArg); };
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)
d5e62be
to
8d17920
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)
commit-id:c7ed8ab4
8d17920
to
0d656bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)
Stack:
This change is