Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional model parameter #133

Closed
wants to merge 31 commits into from

Conversation

rowinho
Copy link

@rowinho rowinho commented Sep 18, 2023

Adding optional "model" parameter for discovery, in order to allow consumers (e.g. Homeassistant) to specify inverter model for quicker discovery.

This addresses issues where discovery takes long time to complete, sometimes not completing at all.

Adding get_models() allowing conumers (e.g. Homeassistant) to retrieve list of supported inveter models.
@luismsousa
Copy link

Giving it a bump to check if someone can review and merge.

@squishykid
Copy link
Owner

squishykid commented Feb 7, 2024

Can you please have a look at why the tests aren't running? I would like to run the tests before doing a review

@luismsousa
Copy link

luismsousa commented Feb 8, 2024

Can you please have a look at why the tests aren't running? I would like to run the tests before doing a review

@squishykid I've re-submitted @rowinho 's PR as I couldn't push to his fork. I've opened #140 to force the trigger for the github action. https://github.com/squishykid/solax/actions/runs/7833149301 it's waiting your action for it to start. Cheers 👋

You might need to cancel the github action that's hanging. Alternatively, feel free to make me a contributor/maintainer and I'll help troubleshoot the actions.

@squishykid
Copy link
Owner

I just modified the settings on solax, so I shouldn't need to approve the github actions as often for new contributors.

@Darsstar
Copy link
Contributor

Darsstar commented Apr 2, 2024

This PR can probably be closed since #145 has been merged.

@squishykid squishykid closed this Apr 2, 2024
@rowinho rowinho deleted the optional-model-parameter branch June 26, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants