-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional model parameter #133
Conversation
Masking discovery issues by enabling X3HybridG4 only
Change "yield today" to class Total()
Update from squishykid/solax master
Adding get_models() allowing conumers (e.g. Homeassistant) to retrieve list of supported inveter models.
Giving it a bump to check if someone can review and merge. |
Can you please have a look at why the tests aren't running? I would like to run the tests before doing a review |
@squishykid I've re-submitted @rowinho 's PR as I couldn't push to his fork. I've opened #140 to force the trigger for the github action. https://github.com/squishykid/solax/actions/runs/7833149301 it's waiting your action for it to start. Cheers 👋 You might need to cancel the github action that's hanging. Alternatively, feel free to make me a contributor/maintainer and I'll help troubleshoot the actions. |
I just modified the settings on |
This PR can probably be closed since #145 has been merged. |
Adding optional "model" parameter for discovery, in order to allow consumers (e.g. Homeassistant) to specify inverter model for quicker discovery.
This addresses issues where discovery takes long time to complete, sometimes not completing at all.