Make it possible to specify the inverter type when initializing the library, and bypass the discovery process. #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the case where the Inverter type is already known. Some inverters at the end of the REGISTRY (e.g. X1HybridGen4) randomly crash because the discovery code issues too many incorrect requests before sending the correct one. This patch adds a variant of the entry point in which one can specify the name of the inverter type. This addresses home-assistant/core#66617 and home-assistant/core#99421
|
This is similar to #133 |
|
ok so we now have working solutions to bypass the discovery code: one in this PR, and another in #144 Which do you prefer? I have a prototype solution to the downstream homeassistant problem that I would like to finish up and push. |
|
I have tested #133 and I think it is a better solution: simpler / smaller. It works quite well in HA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the case where the Inverter type is already known.
Some inverters at the end of the REGISTRY (e.g. X1HybridGen4) randomly crash because the discovery code issues too many incorrect requests before sending the correct one.
This patch adds a variant of the entry point in which one can specify the name of the inverter type.
This addresses home-assistant/core#66617 and home-assistant/core#99421