Revert "fix(core): conditionally hide expression evaluation warning messages (#9771)" #10021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbyron-sf
approved these changes
Aug 30, 2023
mattgogerly
added
ready to merge
|
@Mergifyio backport release-1.32.x release-1.31.x release-1.30.x |
✅ Backports have been created
|
|
Not sure whether we're gonna get another 1.29.x out the door, but let's backport it there too just in case. |
|
@Mergifyio backport release-1.29.x |
|
Looks like Mergify and spinnakerbot are chugging today. |
✅ Backports have been created
|
|
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
ryanjohnsontv
added a commit
to homedepot/deck
that referenced
this pull request
Apr 4, 2024
* fix: UI crashes when running pipeline(s) with many stages. (backport spinnaker#9960) (spinnaker#9974) Co-authored-by: armory-abedonik <[email protected]> * Revert "fix(core): conditionally hide expression evaluation warning messages (spinnaker#9771)" (spinnaker#10021) (spinnaker#10025) This reverts commit 7e3dd50. (cherry picked from commit 62033d0) Co-authored-by: Matt Gogerly <[email protected]> * fix: Scaling bounds should parse float not int (spinnaker#10026) (spinnaker#10035) * fix: Scaling bounds should parse float not int Currently the API can do this, the model supports this, but the parseInt removes decimals from the UI * fix: Decimal support for upper/lower bound ASG tests (cherry picked from commit b763cae) Co-authored-by: Jason <[email protected]> * Fix CreateSecurityGroups ternary * Remove failing test for disabled action * Temporally adding GH workflows to build Docker from this branch * Temporally disabling other GHA workflows * Adding 'thd' prefix to IMAGE_NAME env var * Changing image name from 'deck' to 'thd-deck' * Apply master GHA changes --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: armory-abedonik <[email protected]> Co-authored-by: Matt Gogerly <[email protected]> Co-authored-by: Jason <[email protected]> Co-authored-by: Rodrigo Tovar <[email protected]>
sahititarigoppula
pushed a commit
to OpsMx/deck-oes
that referenced
this pull request
May 31, 2024
…essages (spinnaker#9771)" (spinnaker#10021) (spinnaker#10023) This reverts commit 7e3dd50. (cherry picked from commit 62033d0) Co-authored-by: Matt Gogerly <[email protected]>
sahititarigoppula
pushed a commit
to OpsMx/deck-oes
that referenced
this pull request
May 31, 2024
…essages (spinnaker#9771)" (spinnaker#10021) (spinnaker#10022) This reverts commit 7e3dd50. (cherry picked from commit 62033d0) Co-authored-by: Matt Gogerly <[email protected]>
sahititarigoppula
pushed a commit
to OpsMx/deck-oes
that referenced
this pull request
Jun 5, 2024
…essages (spinnaker#9771)" (spinnaker#10021) This reverts commit 7e3dd50.
ryanjohnsontv
added a commit
to homedepot/deck
that referenced
this pull request
Sep 12, 2024
* fix(core): Do not set static document base URL (spinnaker#9890) (spinnaker#9892) The previous change to enable optional path-based routing (spinnaker#9802) added a `<base>` tag, which regressed serving hash-based routing at non-root public paths. This change returns to AngularJS's default behavior when using hash-based routing. Note that path-based routing will continue to only function when served from a domain root. Resolves spinnaker/spinnaker#6723 (cherry picked from commit 5ac7516) Co-authored-by: jcavanagh <[email protected]> * fix(aws): fix instance type selector by allowing instance types that can't be validated. (spinnaker#9893) (spinnaker#9895) * fix(aws): fix instance type selector by allowing instance types that can't be validated. spinnaker/spinnaker#6734 * fix(aws): adding test for instance type selector fix spinnaker/spinnaker#6734 (cherry picked from commit 563b6f6) Co-authored-by: Prathibha Datta Kumar <[email protected]> * fix(links): update link to spinnaker release changelog (spinnaker#9897) (spinnaker#9900) * fix(links): update link to spinnaker release changelog * prettier (cherry picked from commit 1591513) Co-authored-by: Jared Stehler <[email protected]> * fix(aws): Fixing bugs related to clone CX when instance types are incompatible with image/region (spinnaker#9901) (spinnaker#9907) * fix(aws): Fixing bugs related to clone UX when instance types are incompatible with image/region Displaying warnings when incompatible instance types are removed spinnaker/spinnaker#6734 * fix(aws): PR feedback Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit d7290c4) Co-authored-by: Prathibha Datta Kumar <[email protected]> * chore(dependencies): Autobump spinnakerGradleVersion (spinnaker#9916) (spinnaker#9927) Co-authored-by: root <root@2dd4f76bffcc> (cherry picked from commit 64d03bc) Co-authored-by: spinnakerbot <[email protected]> * feat(pipeline): added feature flag for pipeline when mj stage child (spinnaker#9914) (spinnaker#9921) * feat(pipeline): added feature flag for pipeline when mj stage child * fix(pipeline): added verification for sub pipe data * added guard verification for undefined data Co-authored-by: Fernando Freire <[email protected]> (cherry picked from commit 4b6fd53) Co-authored-by: Oscar Michel Herrera <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * fix(timeout): Added feature flag for rollback timeout ui input. (backport spinnaker#9937) (spinnaker#9941) * fix(timeout): Added feature flag for rollback timeout ui input. (spinnaker#9937) * fix(timeout): Added feature flag for rollback timeout ui input. * fix(timeout): Added feature flag for rollback timeout ui input. (cherry picked from commit e239be3) # Conflicts: # packages/amazon/src/pipeline/stages/rollbackCluster/rollbackClusterStage.html * fix(timeout): Added feature flag for rollback timeout ui input. (spinnaker#9944) --------- Co-authored-by: DanielaS12 <[email protected]> * [CN-1890] disable deploy options * fix(google): Resolved typo errors in GCE Autoscaler feature (spinnaker#9947) * Publish packages to NPM (spinnaker#9949) * chore(publish): publish packages (2250a47) - [email protected] - @spinnaker/[email protected] * feat(peerdep-sync): Synchronize peerdependencies * chore(publish): publish peerdeps (2250a47) - @spinnaker/[email protected] --------- Co-authored-by: spinnakerbot <[email protected]> * [CN-1890] remove extra true * fix(6755): Resolved issue regarding warning reporting when cloning a server group in AWS (spinnaker#9948) * Revert "feat(Blue/Green): Add warning label and enhance disable/enable manifest stage with Deployment kind." (spinnaker#9951) * chore(dev): specifying React code for Deck PRs (spinnaker#9953) Co-authored-by: Cameron Motevasselani <[email protected]> * feat(provider/cloudrun): Added cloudrun functionality to deck (spinnaker#9931) * feat(provider/cloudrun): Added cloudrun functionality to deck * feat(provider/cloudrun): Incorporated Suggested Changes * feat(provider/cloudRun): Fixed build issue --------- Co-authored-by: rsinghsidhu <[email protected]> * chore(feature-flag): mj parent pipeline enabled by default (spinnaker#9954) Co-authored-by: ovidiupopa07 <[email protected]> * Publish packages to NPM (spinnaker#9955) * chore(publish): publish packages (e1b8d70) - [email protected] * feat(peerdep-sync): Synchronize peerdependencies * chore(publish): publish peerdeps (e1b8d70) - @spinnaker/[email protected] --------- Co-authored-by: spinnakerbot <[email protected]> * feat(deck): make StageFailureMessage component overridable (backport spinnaker#9994) (spinnaker#10007) * feat(deck): make StageFailureMessage component overridable (spinnaker#9994) (cherry picked from commit 39f70cc) # Conflicts: # version.json * chore(build): fix backport merge conflict --------- Co-authored-by: Matt <[email protected]> * Revert "fix(core): conditionally hide expression evaluation warning messages (spinnaker#9771)" (spinnaker#10021) (spinnaker#10024) This reverts commit 7e3dd50. (cherry picked from commit 62033d0) Co-authored-by: Matt Gogerly <[email protected]> * fix: Scaling bounds should parse float not int (spinnaker#10026) (spinnaker#10031) * fix: Scaling bounds should parse float not int Currently the API can do this, the model supports this, but the parseInt removes decimals from the UI * fix: Decimal support for upper/lower bound ASG tests (cherry picked from commit b763cae) Co-authored-by: Jason <[email protected]> * feat(helm/bake): Add additional input fields where we can fill in details of the APIs versions (spinnaker#10036) (spinnaker#10046) - These input fields will not be pre-populated with versions of the target cluster available in the environment. - They will become part of the bake result. - Added API_VERSIONS_ENABLED env variable flag (cherry picked from commit d968183) Co-authored-by: Krystian <[email protected]> * fix: Updating Lambda functions available Runtimes (spinnaker#10055) (spinnaker#10056) (cherry picked from commit 669d1ed) Co-authored-by: Christos Arvanitis <[email protected]> * Update 1.29.7 (#3) * fix: UI crashes when running pipeline(s) with many stages. (backport spinnaker#9960) (spinnaker#9974) Co-authored-by: armory-abedonik <[email protected]> * Revert "fix(core): conditionally hide expression evaluation warning messages (spinnaker#9771)" (spinnaker#10021) (spinnaker#10025) This reverts commit 7e3dd50. (cherry picked from commit 62033d0) Co-authored-by: Matt Gogerly <[email protected]> * fix: Scaling bounds should parse float not int (spinnaker#10026) (spinnaker#10035) * fix: Scaling bounds should parse float not int Currently the API can do this, the model supports this, but the parseInt removes decimals from the UI * fix: Decimal support for upper/lower bound ASG tests (cherry picked from commit b763cae) Co-authored-by: Jason <[email protected]> * Fix CreateSecurityGroups ternary * Remove failing test for disabled action * Temporally adding GH workflows to build Docker from this branch * Temporally disabling other GHA workflows * Adding 'thd' prefix to IMAGE_NAME env var * Changing image name from 'deck' to 'thd-deck' * Apply master GHA changes --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: armory-abedonik <[email protected]> Co-authored-by: Matt Gogerly <[email protected]> Co-authored-by: Jason <[email protected]> Co-authored-by: Rodrigo Tovar <[email protected]> * Update GHA branch name * Disable cloudrun "Edit Load Balancer" --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: jcavanagh <[email protected]> Co-authored-by: Prathibha Datta Kumar <[email protected]> Co-authored-by: Jared Stehler <[email protected]> Co-authored-by: spinnakerbot <[email protected]> Co-authored-by: Oscar Michel Herrera <[email protected]> Co-authored-by: DanielaS12 <[email protected]> Co-authored-by: pjberry16 <[email protected]> Co-authored-by: SusmithaGundu <[email protected]> Co-authored-by: Spinnaker Bot <[email protected]> Co-authored-by: spinnakerbot <[email protected]> Co-authored-by: pjberry16 <[email protected]> Co-authored-by: Rajinderpal Singh Siddhu <[email protected]> Co-authored-by: Cameron Motevasselani <[email protected]> Co-authored-by: Cameron Motevasselani <[email protected]> Co-authored-by: rsinghsidhu <[email protected]> Co-authored-by: Krzysztof Kotula <[email protected]> Co-authored-by: ovidiupopa07 <[email protected]> Co-authored-by: Matt <[email protected]> Co-authored-by: Jason <[email protected]> Co-authored-by: Krystian <[email protected]> Co-authored-by: Christos Arvanitis <[email protected]> Co-authored-by: armory-abedonik <[email protected]> Co-authored-by: Rodrigo Tovar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "fix(core): conditionally hide expression evaluation warning messages (#9771)"
This reverts commit 7e3dd50.
This is the cause of spinnaker/spinnaker#6869, which occurs when there are expression evaluation failures in addition to actual task failures.
Deck merges all failure messages found in a stage into a single string which is then passed to this component. If there are any expression evaluation failures they are always first in the string, so the filter for
Failed to evaluateis removing the entire thing rather than just the expression failures as intended.