Skip to content

Commit

Permalink
Release 1.30.x (#5)
Browse files Browse the repository at this point in the history
* fix(core): Do not set static document base URL (spinnaker#9890) (spinnaker#9892)

The previous change to enable optional path-based routing (spinnaker#9802) added a `<base>` tag, which regressed serving hash-based routing at non-root public paths.

This change returns to AngularJS's default behavior when using hash-based routing.  Note that path-based routing will continue to only function when served from a domain root.

Resolves spinnaker/spinnaker#6723

(cherry picked from commit 5ac7516)

Co-authored-by: jcavanagh <[email protected]>

* fix(aws): fix instance type selector by allowing instance types that can't be validated. (spinnaker#9893) (spinnaker#9895)

* fix(aws): fix instance type selector by allowing instance types that can't be validated.

spinnaker/spinnaker#6734

* fix(aws): adding test for instance type selector fix

spinnaker/spinnaker#6734
(cherry picked from commit 563b6f6)

Co-authored-by: Prathibha Datta Kumar <[email protected]>

* fix(links): update link to spinnaker release changelog (spinnaker#9897) (spinnaker#9900)

* fix(links): update link to spinnaker release changelog

* prettier

(cherry picked from commit 1591513)

Co-authored-by: Jared Stehler <[email protected]>

* fix(aws): Fixing bugs related to clone CX when instance types are incompatible with image/region (spinnaker#9901) (spinnaker#9907)

* fix(aws): Fixing bugs related to clone UX when instance types are incompatible with image/region

Displaying warnings when incompatible instance types are removed

spinnaker/spinnaker#6734

* fix(aws): PR feedback

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit d7290c4)

Co-authored-by: Prathibha Datta Kumar <[email protected]>

* chore(dependencies): Autobump spinnakerGradleVersion (spinnaker#9916) (spinnaker#9927)

Co-authored-by: root <root@2dd4f76bffcc>
(cherry picked from commit 64d03bc)

Co-authored-by: spinnakerbot <[email protected]>

* feat(pipeline): added feature flag for pipeline when mj stage child (spinnaker#9914) (spinnaker#9921)

* feat(pipeline): added feature flag for pipeline when mj stage child

* fix(pipeline): added verification for sub pipe data

* added guard verification for undefined data

Co-authored-by: Fernando Freire <[email protected]>
(cherry picked from commit 4b6fd53)

Co-authored-by: Oscar Michel Herrera <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* fix(timeout): Added feature flag for rollback timeout ui input. (backport spinnaker#9937) (spinnaker#9941)

* fix(timeout): Added feature flag for rollback timeout ui input. (spinnaker#9937)

* fix(timeout): Added feature flag for rollback timeout ui input.

* fix(timeout): Added feature flag for rollback timeout ui input.

(cherry picked from commit e239be3)

# Conflicts:
#	packages/amazon/src/pipeline/stages/rollbackCluster/rollbackClusterStage.html

* fix(timeout): Added feature flag for rollback timeout ui input. (spinnaker#9944)

---------

Co-authored-by: DanielaS12 <[email protected]>

* [CN-1890] disable deploy options

* fix(google): Resolved typo errors in GCE Autoscaler feature (spinnaker#9947)

* Publish packages to NPM (spinnaker#9949)

* chore(publish): publish packages (2250a47)

 - [email protected]
 - @spinnaker/[email protected]

* feat(peerdep-sync): Synchronize peerdependencies

* chore(publish): publish peerdeps (2250a47)

 - @spinnaker/[email protected]

---------

Co-authored-by: spinnakerbot <[email protected]>

* [CN-1890] remove extra true

* fix(6755): Resolved issue regarding warning reporting when cloning a server group in AWS (spinnaker#9948)

* Revert "feat(Blue/Green): Add warning label and enhance disable/enable manifest stage with Deployment kind." (spinnaker#9951)

* chore(dev): specifying React code for Deck PRs (spinnaker#9953)

Co-authored-by: Cameron Motevasselani <[email protected]>

* feat(provider/cloudrun): Added cloudrun functionality to deck (spinnaker#9931)

* feat(provider/cloudrun): Added cloudrun functionality to deck

* feat(provider/cloudrun): Incorporated Suggested Changes

* feat(provider/cloudRun): Fixed build issue

---------

Co-authored-by: rsinghsidhu <[email protected]>

* chore(feature-flag): mj parent pipeline enabled by default (spinnaker#9954)

Co-authored-by: ovidiupopa07 <[email protected]>

* Publish packages to NPM (spinnaker#9955)

* chore(publish): publish packages (e1b8d70)

 - [email protected]

* feat(peerdep-sync): Synchronize peerdependencies

* chore(publish): publish peerdeps (e1b8d70)

 - @spinnaker/[email protected]

---------

Co-authored-by: spinnakerbot <[email protected]>

* feat(deck): make StageFailureMessage component overridable (backport spinnaker#9994) (spinnaker#10007)

* feat(deck): make StageFailureMessage component overridable (spinnaker#9994)

(cherry picked from commit 39f70cc)

# Conflicts:
#	version.json

* chore(build): fix backport merge conflict

---------

Co-authored-by: Matt <[email protected]>

* Revert "fix(core): conditionally hide expression evaluation warning messages (spinnaker#9771)" (spinnaker#10021) (spinnaker#10024)

This reverts commit 7e3dd50.

(cherry picked from commit 62033d0)

Co-authored-by: Matt Gogerly <[email protected]>

* fix: Scaling bounds should parse float not int (spinnaker#10026) (spinnaker#10031)

* fix: Scaling bounds should parse float not int

Currently the API can do this, the model supports this, but the parseInt removes decimals from the UI

* fix: Decimal support for upper/lower bound ASG tests

(cherry picked from commit b763cae)

Co-authored-by: Jason <[email protected]>

* feat(helm/bake): Add additional input fields where we can fill in details of the APIs versions (spinnaker#10036) (spinnaker#10046)

- These input fields will not be pre-populated with versions of the target cluster available in the environment.

- They will become part of the bake result.

- Added API_VERSIONS_ENABLED env variable flag

(cherry picked from commit d968183)

Co-authored-by: Krystian <[email protected]>

* fix: Updating Lambda functions available Runtimes (spinnaker#10055) (spinnaker#10056)

(cherry picked from commit 669d1ed)

Co-authored-by: Christos Arvanitis <[email protected]>

* Update 1.29.7 (#3)

* fix: UI crashes when running pipeline(s) with many stages. (backport spinnaker#9960) (spinnaker#9974)

Co-authored-by: armory-abedonik <[email protected]>

* Revert "fix(core): conditionally hide expression evaluation warning messages (spinnaker#9771)" (spinnaker#10021) (spinnaker#10025)

This reverts commit 7e3dd50.

(cherry picked from commit 62033d0)

Co-authored-by: Matt Gogerly <[email protected]>

* fix: Scaling bounds should parse float not int (spinnaker#10026) (spinnaker#10035)

* fix: Scaling bounds should parse float not int

Currently the API can do this, the model supports this, but the parseInt removes decimals from the UI

* fix: Decimal support for upper/lower bound ASG tests

(cherry picked from commit b763cae)

Co-authored-by: Jason <[email protected]>

* Fix CreateSecurityGroups ternary

* Remove failing test for disabled action

* Temporally adding GH workflows to build Docker from this branch

* Temporally disabling other GHA workflows

* Adding 'thd' prefix to IMAGE_NAME env var

* Changing image name from 'deck' to 'thd-deck'

* Apply master GHA changes

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: armory-abedonik <[email protected]>
Co-authored-by: Matt Gogerly <[email protected]>
Co-authored-by: Jason <[email protected]>
Co-authored-by: Rodrigo Tovar <[email protected]>

* Update GHA branch name

* Disable cloudrun "Edit Load Balancer"

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: jcavanagh <[email protected]>
Co-authored-by: Prathibha Datta Kumar <[email protected]>
Co-authored-by: Jared Stehler <[email protected]>
Co-authored-by: spinnakerbot <[email protected]>
Co-authored-by: Oscar Michel Herrera <[email protected]>
Co-authored-by: DanielaS12 <[email protected]>
Co-authored-by: pjberry16 <[email protected]>
Co-authored-by: SusmithaGundu <[email protected]>
Co-authored-by: Spinnaker Bot <[email protected]>
Co-authored-by: spinnakerbot <[email protected]>
Co-authored-by: pjberry16 <[email protected]>
Co-authored-by: Rajinderpal Singh Siddhu <[email protected]>
Co-authored-by: Cameron Motevasselani <[email protected]>
Co-authored-by: Cameron Motevasselani <[email protected]>
Co-authored-by: rsinghsidhu <[email protected]>
Co-authored-by: Krzysztof Kotula <[email protected]>
Co-authored-by: ovidiupopa07 <[email protected]>
Co-authored-by: Matt <[email protected]>
Co-authored-by: Jason <[email protected]>
Co-authored-by: Krystian <[email protected]>
Co-authored-by: Christos Arvanitis <[email protected]>
Co-authored-by: armory-abedonik <[email protected]>
Co-authored-by: Rodrigo Tovar <[email protected]>
  • Loading branch information
1 parent d733acc commit 89d300f
Show file tree
Hide file tree
Showing 96 changed files with 2,947 additions and 280 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ on:
workflow_call:
inputs:
BRANCH:
description: "Git branch to fetch code from"
description: Git branch to fetch code from
required: true
default: "master"
default: main
type: string

env:
Expand Down
26 changes: 13 additions & 13 deletions .github/workflows/docker-build.yml
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
name: "Build Docker image for Deck and push it to GitHub Container Registry"
name: Build Docker image for Deck and push it to GitHub Container Registry

on:
workflow_call:
inputs:
IMAGE_VERSION:
description: "Version to use for image tag"
required: true
default: "0.0.0"
type: string
BRANCH:
description: "Git branch to fetch code from"
required: true
default: "master"
type: string
workflow_call:
inputs:
IMAGE_VERSION:
description: Version to use for image tag
required: true
default: "0.0.0"
type: string
BRANCH:
description: Git branch to fetch code from
required: true
default: main
type: string

env:
CONTAINER_REGISTRY: ghcr.io
Expand Down
30 changes: 15 additions & 15 deletions .github/workflows/pr-build.yml
Original file line number Diff line number Diff line change
@@ -1,28 +1,28 @@
name: Release

on:
workflow_dispatch:
inputs:
BRANCH:
description: 'Git branch to fetch code from'
required: true
default: 'master'
type: string
THD_DECK_VERSION:
description: 'Version of THD Deck'
required: true
default: "0.0.0"
type: string
workflow_dispatch:
inputs:
BRANCH:
description: Git branch to fetch code from
required: true
default: main
type: string
THD_DECK_VERSION:
description: Version of THD Deck
required: true
default: "0.0.0"
type: string

jobs:
build:
uses: ./.github/workflows/build.yml
with:
BRANCH: ${{ inputs.BRANCH }}
BRANCH: ${{ inputs.BRANCH }}

docker:
needs: build
uses: ./.github/workflows/docker-build.yml
with:
BRANCH: ${{ inputs.BRANCH }}
IMAGE_VERSION: ${{ inputs.THD_DECK_VERSION }}
BRANCH: ${{ inputs.BRANCH }}
IMAGE_VERSION: ${{ inputs.THD_DECK_VERSION }}
47 changes: 47 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ The following external resources can be specified with environment variables:

For example, `API_HOST=http://spinnaker.prod.netflix.net yarn start` will run Deck with `http://spinnaker.prod.netflix.net` as the API host.

## Development

Deck has a combination of Angular and React, but is moving to React only. New changes made to the Deck project should use React wherever possible.

## Testing

To run the tests within the application, run `yarn test`.
Expand Down Expand Up @@ -77,3 +81,46 @@ those existing conventions if you need an integration point that doesn't already

Interested in sharing feedback on Spinnaker's UI or contributing to Deck?
Please join us at the [Spinnaker UI SIG](https://github.com/spinnaker/governance/tree/master/sig-ui-ux)!

<hr>

# THD-DECK Docs

<hr>

## THD-Deck Sandbox Installation Instructions

### Build a local image
- `yarn`
- `yarn modules`
- `yarn build`


### Push the local image to Artifactory
Once you build a local image, run the following commands:

```shell
THD_DECK_VERSION={new image number}
```
```shell
docker build --platform linux/amd64 -f Dockerfile.ubuntu -t docker.artifactory.homedepot.com/cd/thd-deck:${THD_DECK_VERSION} .
```
```shell
docker tag docker.artifactory.homedepot.com/cd/thd-deck:${THD_DECK_VERSION} us.gcr.io/np-te-cd-tools/cd/thd-deck:${THD_DECK_VERSION}
```
```shell
docker push docker.artifactory.homedepot.com/cd/thd-deck:${THD_DECK_VERSION}
```

### Push the image from Artifactory to GCR
Once the image is pushed to docker.artifactory a Slingshot stage needs to be used
to move the image from Artifactory to GCR.

Example [pipeline](https://sandbox.spinnaker.homedepot.com/#/applications/cd-thd-deck/executions?pipeline=Push%20Deck%20Image)

### Update Deck image in spin-operator repository
In spin-operator-np-te-cd-tools repository:
1. Create branch named for new Deck version"
2. In deploy/spinnaker/np-te-cd-tools/overlays/us-dev1/service-settings.yml
3. Update artifactId with new `THD_DECK_VERSION`
1. `artifactId: us.gcr.io/np-te-cd-tools/cd/thd-deck:${THD_DECK_VERSION}`
6 changes: 6 additions & 0 deletions halconfig/settings.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@ var cloudfoundry = {
account: '{%cloudfoundry.default.account%}',
},
};
var cloudrun = {
defaults: {
account: '{%cloudrun.default.account%}',
},
};
var dcos = {
defaults: {
account: '{%dcos.default.account%}',
Expand Down Expand Up @@ -145,6 +150,7 @@ window.spinnakerSettings = {
aws: aws,
azure: azure,
cloudfoundry: cloudfoundry,
cloudrun: cloudrun,
dcos: dcos,
ecs: ecs,
gce: gce,
Expand Down
3 changes: 3 additions & 0 deletions karma-shim.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ testContext.keys().forEach(testContext);
testContext = require.context('./packages/cloudfoundry/src', true, /\.spec\.(js|ts|tsx)$/);
testContext.keys().forEach(testContext);

testContext = require.context('./packages/cloudrun/src', true, /\.spec\.(js|ts|tsx)$/);
testContext.keys().forEach(testContext);

testContext = require.context('./packages/core/src', true, /\.spec\.(js|ts|tsx)$/);
testContext.keys().forEach(testContext);

Expand Down
2 changes: 2 additions & 0 deletions karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ const webpackConfig = {
'@spinnaker/azure': path.resolve(`${MODULES_ROOT}/azure/src`),
cloudfoundry: path.resolve(`${MODULES_ROOT}/cloudfoundry/src`),
'@spinnaker/cloudfoundry': path.resolve(`${MODULES_ROOT}/cloudfoundry/src`),
cloudrun: path.resolve(`${MODULES_ROOT}/cloudrun/src`),
'@spinnaker/cloudrun': path.resolve(`${MODULES_ROOT}/cloudrun/src`),
core: path.resolve(`${MODULES_ROOT}/core/src`),
'@spinnaker/core': path.resolve(`${MODULES_ROOT}/core/src`),
dcos: path.resolve(`${MODULES_ROOT}/dcos/src`),
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@
"packages/appengine",
"packages/azure",
"packages/cloudfoundry",
"packages/cloudrun",
"packages/core",
"packages/dcos",
"packages/docker",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,20 +20,26 @@ import type { IAmazonFunction } from '../../domain';
import type { IAmazonFunctionUpsertCommand } from '../../index';

const availableRuntimes = [
'nodejs10.x',
'nodejs12.x',
'nodejs14.x',
'nodejs16.x',
'nodejs18.x',
'java8',
'java8.al2',
'java11',
'python2.7',
'python3.6',
'java17',
'python3.7',
'python3.8',
'dotnetcore2.1',
'python3.9',
'python3.10',
'dotnetcore3.1',
'dotnet7',
'dotnet6',
'dotnet5.0',
'go1.x',
'ruby2.5',
'ruby2.7',
'provided',
'provided.al2',
];

export interface IFunctionProps {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export const StepPolicyAction = ({
value={step.metricIntervalLowerBound}
max={step.metricIntervalUpperBound}
onChange={(e) =>
updateStep({ ...step, metricIntervalLowerBound: Number.parseInt(e.target.value) }, index)
updateStep({ ...step, metricIntervalLowerBound: Number.parseFloat(e.target.value) }, index)
}
inputClassName="action-input"
/>
Expand All @@ -122,7 +122,7 @@ export const StepPolicyAction = ({
value={step.metricIntervalUpperBound}
min={step.metricIntervalLowerBound}
onChange={(e) =>
updateStep({ ...step, metricIntervalUpperBound: Number.parseInt(e.target.value) }, index)
updateStep({ ...step, metricIntervalUpperBound: Number.parseFloat(e.target.value) }, index)
}
inputClassName="action-input"
/>
Expand Down
19 changes: 19 additions & 0 deletions packages/app/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,25 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [2.5.0](https://github.com/spinnaker/deck/compare/[email protected]@2.5.0) (2023-03-15)


### Features

* **provider/cloudrun:** Added cloudrun functionality to deck ([#9931](https://github.com/spinnaker/deck/issues/9931)) ([3611e95](https://github.com/spinnaker/deck/commit/3611e9520b2294454a8b5dddc85cb3190722ffc7))





## [2.4.3](https://github.com/spinnaker/deck/compare/[email protected]@2.4.3) (2023-02-20)

**Note:** Version bump only for package deck-app





## [2.4.2](https://github.com/spinnaker/deck/compare/[email protected]@2.4.2) (2023-02-07)

**Note:** Version bump only for package deck-app
Expand Down
5 changes: 3 additions & 2 deletions packages/app/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "deck-app",
"private": true,
"version": "2.4.2",
"version": "2.5.0",
"description": "",
"main": "index.js",
"scripts": {
Expand All @@ -17,10 +17,11 @@
"@spinnaker/amazon": "^0.13.5",
"@spinnaker/appengine": "^0.1.3",
"@spinnaker/cloudfoundry": "^0.1.3",
"@spinnaker/cloudrun": "^0.0.1",
"@spinnaker/core": "^0.23.0",
"@spinnaker/docker": "^0.0.137",
"@spinnaker/ecs": "^0.0.356",
"@spinnaker/google": "^0.2.3",
"@spinnaker/google": "^0.2.4",
"@spinnaker/kayenta": "2.0.0",
"@spinnaker/kubernetes": "^0.4.0",
"@spinnaker/oracle": "^0.0.81",
Expand Down
2 changes: 2 additions & 0 deletions packages/app/src/app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import { ORACLE_MODULE } from '@spinnaker/oracle';
import { KAYENTA_MODULE } from '@spinnaker/kayenta';
import { TITUS_MODULE } from '@spinnaker/titus';
import { ECS_MODULE } from '@spinnaker/ecs';
import { CLOUDRUN_MODULE } from '@spinnaker/cloudrun';
import '@spinnaker/cloudfoundry';

module('netflix.spinnaker', [
Expand All @@ -30,4 +31,5 @@ module('netflix.spinnaker', [
KUBERNETES_MODULE,
KAYENTA_MODULE,
TITUS_MODULE,
CLOUDRUN_MODULE,
]);
11 changes: 10 additions & 1 deletion packages/app/src/settings.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,15 @@ const managedServiceAccountsEnabled =
process.env.MANAGED_SERVICE_ACCOUNTS_ENABLED === 'true';
const managedResourcesEnabled =
import.meta.env.VITE_MANAGED_RESOURCES_ENABLED === 'true' || process.env.MANAGED_RESOURCES_ENABLED === 'true';
const manualJudgmentParentPipelineEnabled = import.meta.env.MJ_PARENTPIPELINE_ENABLED === 'true' || false;
const manualJudgmentParentPipelineEnabled = import.meta.env.MJ_PARENTPIPELINE_ENABLED !== 'false';
const onDemandClusterThreshold =
import.meta.env.VITE_ON_DEMAND_CLUSTER_THRESHOLD || process.env.ON_DEMAND_CLUSTER_THRESHOLD || '350';
const reduxLoggerEnabled = import.meta.env.VITE_REDUX_LOGGER === 'true' || process.env.REDUX_LOGGER === 'true';
const templatesEnabled = import.meta.env.VITE_TEMPLATES_ENABLED === 'true' || process.env.TEMPLATES_ENABLED === 'true';
const useClassicFirewallLabels =
import.meta.env.VITE_USE_CLASSIC_FIREWALL_LABELS === 'true' || process.env.USE_CLASSIC_FIREWALL_LABELS === 'true';
const helmApiVersionsEnabled =
import.meta.env.VITE_API_VERSIONS_ENABLED === 'true' || process.env.API_VERSIONS_ENABLED === 'true' || false;
const functionsEnabled =
import.meta.env.VITE_FUNCTIONS_ENABLED === 'true' || process.env.FUNCTIONS_ENABLED === 'true' || false;
const k8sRawResourcesEnabled =
Expand Down Expand Up @@ -91,6 +93,7 @@ window.spinnakerSettings = {
'aws',
'azure',
'cloudfoundry',
'cloudrun',
'dcos',
'ecs',
'gce',
Expand Down Expand Up @@ -130,6 +133,7 @@ window.spinnakerSettings = {
slack: false,
snapshots: false,
functions: functionsEnabled,
helmApiVersions: helmApiVersionsEnabled,
kubernetesRawResources: k8sRawResourcesEnabled,
},
gateUrl: apiHost,
Expand Down Expand Up @@ -211,6 +215,11 @@ window.spinnakerSettings = {
account: 'my-cloudfoundry-account',
},
},
cloudrun: {
defaults: {
account: 'my-cloudrun-account',
},
},
dcos: {
defaults: {
account: 'my-dcos-account',
Expand Down
2 changes: 1 addition & 1 deletion packages/appengine/src/loadBalancer/details/details.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ <h3 class="horizontal middle space-between flex-1" select-on-dbl-click>{{ctrl.lo
Load Balancer Actions <span class="caret"></span>
</button>
<ul class="dropdown-menu" uib-dropdown-menu role="menu">
<li><a href ng-click="ctrl.editLoadBalancer()">Edit Load Balancer</a></li>
<li class="disabled"><a>Edit Load Balancer</a></li>
<li ng-if="ctrl.canDeleteLoadBalancer()">
<a href ng-click="ctrl.deleteLoadBalancer()">Delete Load Balancer</a>
</li>
Expand Down
3 changes: 2 additions & 1 deletion packages/appengine/src/serverGroup/details/details.html
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,9 @@ <h3 class="horizontal middle space-between flex-1" select-on-dbl-click>{{ctrl.se
uib-tooltip="It is not possible to clone an App Engine server group's full
launch configuration. However, clicking this button will allow
you to deploy into this server group's cluster."
class="disabled"
>
<a href ng-click="ctrl.cloneServerGroup()">Clone</a>
<a>Clone</a>
</li>
</ul>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ <h3 class="horizontal middle space-between flex-1" select-on-dbl-click>{{loadBal
Load Balancer Actions <span class="caret"></span>
</button>
<ul class="dropdown-menu" uib-dropdown-menu role="menu">
<li><a href ng-click="ctrl.editLoadBalancer()">Edit Load Balancer</a></li>
<li class="disabled"><a>Edit Load Balancer</a></li>
<li ng-if="!loadBalancer.serverGroups.length">
<a href ng-click="ctrl.deleteLoadBalancer()">Delete Load Balancer</a>
</li>
Expand Down
4 changes: 4 additions & 0 deletions packages/cloudrun/.npmignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
yalc.*
.*
tsconfig.json
webpack.config.js
Loading

0 comments on commit 89d300f

Please sign in to comment.