docs: modify calico instructions for multi-nic case #4050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lennessyy
requested review from
karl-cardenas-coding,
addetz,
caroldelwing and
vipsharm
❌ Deploy Preview for docs-spectrocloud failed. Why did it fail? →
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
vipsharm
approved these changes
Sep 24, 2024
karl-cardenas-coding
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Approved. @lennessyy any chance you can get the table on item 10 indented please? 😄
lennessyy
added
auto-backport
| | --------------- | ----------------------------------------------------------------------------------------------------------------------------------- | | ||
| | IP address | The static IP address assigned to your Edge host. This should be unique within your network. | | ||
| | Default gateway | The IP address of the default gateway for your cluster network. This gateway routes traffic from your cluster to external networks. | | ||
| | Subnet mask | The subnet mask of your cluster network. This defines the range of IP addresses within your cluster network. | |
There was a problem hiding this comment.
🚫 [vale] reported by reviewdog 🐶
[Vale.Terms] Use 'subnet' instead of 'Subnet'.
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
* docs: modify calico instructions for multi-nic case * docs: modify sample code * docs: identation --------- Co-authored-by: Lenny Chen <[email protected]> (cherry picked from commit 59d4359)
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
* docs: modify calico instructions for multi-nic case * docs: modify sample code * docs: identation --------- Co-authored-by: Lenny Chen <[email protected]> (cherry picked from commit 59d4359)
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
* docs: modify calico instructions for multi-nic case * docs: modify sample code * docs: identation --------- Co-authored-by: Lenny Chen <[email protected]> (cherry picked from commit 59d4359)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Merged
2 tasks
vault-token-factory-spectrocloud bot
added a commit
that referenced
this pull request
Sep 25, 2024
) (#4074) * docs: modify calico instructions for multi-nic case (#4050) * docs: modify calico instructions for multi-nic case * docs: modify sample code * docs: identation --------- Co-authored-by: Lenny Chen <[email protected]> (cherry picked from commit 59d4359) * docs: fix syntax issue --------- Co-authored-by: Lenny Chen <[email protected]> Co-authored-by: Lenny Chen <[email protected]>
vault-token-factory-spectrocloud bot
added a commit
that referenced
this pull request
Sep 25, 2024
) (#4073) * docs: modify calico instructions for multi-nic case (#4050) * docs: modify calico instructions for multi-nic case * docs: modify sample code * docs: identation --------- Co-authored-by: Lenny Chen <[email protected]> (cherry picked from commit 59d4359) * docs: fix indentation * docs: indentation --------- Co-authored-by: Lenny Chen <[email protected]> Co-authored-by: Lenny Chen <[email protected]>
This was referenced Oct 8, 2024
Merged
Merged
|
🎉 This issue has been resolved in version 4.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Change
This PR modifies calico instructions for multi-nic scenarios.
Changed Pages
💻 Create Cluster Definition
Jira Tickets
🎫 PE-5107
Backports
Can this PR be backported?