Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: pxk-license #4258

Merged
merged 4 commits into from
Oct 10, 2024
Merged

docs: pxk-license #4258

merged 4 commits into from
Oct 10, 2024

Conversation

karl-cardenas-coding
Copy link
Contributor

Describe the Change

This PR captures more information about PXK.

Changed Pages

💻 Add Preview URL for Page

Backports

Can this PR be backported?

  • Yes. Remember to add the relevant backport labels to your PR.
  • No. Please leave a short comment below about why this PR cannot be backported.

@karl-cardenas-coding karl-cardenas-coding added auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 labels Oct 10, 2024
@karl-cardenas-coding karl-cardenas-coding requested a review from a team as a code owner October 10, 2024 18:18
@karl-cardenas-coding karl-cardenas-coding added the backport-version-4-0 Backport change to version 4.0 label Oct 10, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 10, 2024 •
edited
Loading

✅ Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 5a145b7
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/67082665b49f2a00089eb474
😎 Deploy Preview https://deploy-preview-4258--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

caroldelwing
caroldelwing approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@caroldelwing caroldelwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just tiny suggestions :)

docs/docs-content/legal-licenses/oss-licenses-index/pxk-oss-licenses.md Outdated Show resolved Hide resolved
docs/docs-content/legal-licenses/oss-licenses-index/pxk-oss-licenses.md Outdated Show resolved Hide resolved
docs/docs-content/legal-licenses/oss-licenses-index/pxk-oss-licenses.md Outdated Show resolved Hide resolved
@karl-cardenas-coding karl-cardenas-coding merged commit 200ba1f into master Oct 10, 2024
15 checks passed
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Oct 10, 2024
@karl-cardenas-coding
docs: pxk-license (#4258)
308627c 
* docs: pxk-license

* docs: Apply suggestions from code review

Co-authored-by: caroldelwing <[email protected]>

* docs: Apply suggestions from code review

Co-authored-by: caroldelwing <[email protected]>

* ci: auto-formatting prettier issues

---------

Co-authored-by: caroldelwing <[email protected]>
Co-authored-by: karl-cardenas-coding <[email protected]>
(cherry picked from commit 200ba1f)
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Oct 10, 2024
Merged
@vault-token-factory-spectrocloud
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ version-4-0 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-0:
- docs: clarify agent upgrade documentation (#4031)
❌ version-3-4 Backport failed because of merge conflicts

You might need to backport the following PRs to version-3-4:
- docs: remove free-tier mention (#4220)
- docs: clarify agent upgrade documentation (#4031)
- docs: address tutorial suggestions (#3980)
❌ version-4-1 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-1:
- docs: clarify agent upgrade documentation (#4031)
❌ version-4-2 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-2:
- docs: add ubuntu to known issue (#4120)
- docs: modify calico instructions for multi-nic case (#4050)
- docs: add limitation for external registry + content bundle (#4049)
❌ version-4-3 Backport failed because of merge conflicts
✅ version-4-4

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

backport --pr 4258

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

vault-token-factory-spectrocloud bot added a commit that referenced this pull request Oct 10, 2024
@vault-token-factory-spectrocloud @karl-cardenas-coding
docs: pxk-license (#4258) (#4259)
50ae494 
* docs: pxk-license

* docs: Apply suggestions from code review

Co-authored-by: caroldelwing <[email protected]>

* docs: Apply suggestions from code review

Co-authored-by: caroldelwing <[email protected]>

* ci: auto-formatting prettier issues

---------

Co-authored-by: caroldelwing <[email protected]>
Co-authored-by: karl-cardenas-coding <[email protected]>
(cherry picked from commit 200ba1f)

Co-authored-by: Karl Cardenas <[email protected]>
karl-cardenas-coding added a commit that referenced this pull request Oct 10, 2024
@karl-cardenas-coding @caroldelwing
docs: pxk-license (#4258)
f1e6dd0 
* docs: pxk-license

* docs: Apply suggestions from code review

Co-authored-by: caroldelwing <[email protected]>

* docs: Apply suggestions from code review

Co-authored-by: caroldelwing <[email protected]>

* ci: auto-formatting prettier issues

---------

Co-authored-by: caroldelwing <[email protected]>
Co-authored-by: karl-cardenas-coding <[email protected]>
@karl-cardenas-coding karl-cardenas-coding mentioned this pull request Oct 10, 2024
Closed
@vault-token-factory-spectrocloud
Copy link
Contributor

🎉 This issue has been resolved in version 4.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

This was referenced Oct 17, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caroldelwing caroldelwing caroldelwing approved these changes

@addetz addetz Awaiting requested review from addetz addetz is a code owner automatically assigned from spectrocloud/docs-education

@lennessyy lennessyy Awaiting requested review from lennessyy lennessyy is a code owner automatically assigned from spectrocloud/docs-education

Assignees
No one assigned
Labels
auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karl-cardenas-coding @caroldelwing