docs: address tutorial suggestions #3980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caroldelwing
added
backport-version-4-0
✅ Deploy Preview for docs-spectrocloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
caroldelwing
requested review from
karl-cardenas-coding,
addetz and
lennessyy
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 84.8%, saving 1.04 MB.
724 images did not require optimisation. |
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 2%, saving 1.27 KB.
725 images did not require optimisation. |
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
* docs: address tutorial suggestions * docs: vale suggestion * Optimised images with calibre/image-actions * Optimised images with calibre/image-actions --------- Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com> (cherry picked from commit 8ea96da)
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
* docs: address tutorial suggestions * docs: vale suggestion * Optimised images with calibre/image-actions * Optimised images with calibre/image-actions --------- Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com> (cherry picked from commit 8ea96da)
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
* docs: address tutorial suggestions * docs: vale suggestion * Optimised images with calibre/image-actions * Optimised images with calibre/image-actions --------- Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com> (cherry picked from commit 8ea96da)
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
* docs: address tutorial suggestions * docs: vale suggestion * Optimised images with calibre/image-actions * Optimised images with calibre/image-actions --------- Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com> (cherry picked from commit 8ea96da)
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
* docs: address tutorial suggestions * docs: vale suggestion * Optimised images with calibre/image-actions * Optimised images with calibre/image-actions --------- Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com> (cherry picked from commit 8ea96da)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
vault-token-factory-spectrocloud bot
added a commit
that referenced
this pull request
Sep 20, 2024
* docs: address tutorial suggestions * docs: vale suggestion * Optimised images with calibre/image-actions * Optimised images with calibre/image-actions --------- Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com> (cherry picked from commit 8ea96da) Co-authored-by: caroldelwing <[email protected]>
vault-token-factory-spectrocloud bot
added a commit
that referenced
this pull request
Sep 20, 2024
* docs: address tutorial suggestions * docs: vale suggestion * Optimised images with calibre/image-actions * Optimised images with calibre/image-actions --------- Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com> (cherry picked from commit 8ea96da) Co-authored-by: caroldelwing <[email protected]>
vault-token-factory-spectrocloud bot
added a commit
that referenced
this pull request
Sep 20, 2024
* docs: address tutorial suggestions (#3980) * docs: address tutorial suggestions * docs: vale suggestion * Optimised images with calibre/image-actions * Optimised images with calibre/image-actions --------- Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com> (cherry picked from commit 8ea96da) * docs: fix gitleaks --------- Co-authored-by: caroldelwing <[email protected]>
vault-token-factory-spectrocloud bot
added a commit
that referenced
this pull request
Sep 20, 2024
* docs: address tutorial suggestions (#3980) * docs: address tutorial suggestions * docs: vale suggestion * Optimised images with calibre/image-actions * Optimised images with calibre/image-actions --------- Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com> (cherry picked from commit 8ea96da) * retrigger build * docs: fix gitleaks --------- Co-authored-by: caroldelwing <[email protected]>
vault-token-factory-spectrocloud bot
added a commit
that referenced
this pull request
Sep 20, 2024
* docs: address tutorial suggestions (#3980) * docs: address tutorial suggestions * docs: vale suggestion * Optimised images with calibre/image-actions * Optimised images with calibre/image-actions --------- Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com> (cherry picked from commit 8ea96da) * docs: fix gitleaks --------- Co-authored-by: caroldelwing <[email protected]>
|
PS: I've just realized that branch 4-3 has an older version of the tutorial. Therefore, creating the 4-3 backport PR does not make sense. |
1 task
caroldelwing
added a commit
that referenced
this pull request
Sep 24, 2024
* docs: address tutorial suggestions * docs: vale suggestion * Optimised images with calibre/image-actions * Optimised images with calibre/image-actions --------- Co-authored-by: vault-token-factory-spectrocloud[bot] <133815545+vault-token-factory-spectrocloud[bot]@users.noreply.github.com>
This was referenced Oct 8, 2024
Merged
Merged
|
🎉 This issue has been resolved in version 4.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Change
This PR updates the Deploy a Custom Pack tutorial to address a few suggestions:
Changed Pages
💻 Deploy a Custom Pack
Jira Tickets
🎫 DOC-1389
Backports
Can this PR be backported?