Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checksum calculation optimization to lower memory consumption #12

Merged
merged 3 commits into from
Jul 24, 2017
Merged

checksum calculation optimization to lower memory consumption #12

merged 3 commits into from
Jul 24, 2017

Conversation

sparkoo
Copy link
Owner

@sparkoo sparkoo commented Jul 24, 2017 •
edited
Loading

#11

  • Lower memory consumption when calculating checksums. Loading whole box file to byte[] replaced by incremental buffering box file and updating MessageDigest.
  • Advanced property added to tune buffer size.
  • Performance is still not sufficient, thus I'll create new task for precalculating checksums and saving them to file.

@sparkoo sparkoo self-assigned this Jul 24, 2017
@sparkoo sparkoo requested a review from vtelensky July 24, 2017 10:04
@sparkoo sparkoo merged commit 1158d74 into devel Jul 24, 2017
@sparkoo sparkoo mentioned this pull request Jul 25, 2017
Closed
@sparkoo sparkoo deleted the checksum_optimization branch August 9, 2017 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtelensky vtelensky vtelensky approved these changes

Assignees

@sparkoo sparkoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sparkoo @vtelensky