Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checksum calculation optimization #11

Closed
sparkoo opened this issue Jul 21, 2017 · 1 comment
Closed

Checksum calculation optimization #11

sparkoo opened this issue Jul 21, 2017 · 1 comment
Assignees
@sparkoo
Labels
bug

Comments

@sparkoo
Copy link
Owner

sparkoo commented Jul 21, 2017

Checksum calculation takes too much cpu+memory resources for such big files as virtual machines are.

  • Change calculating from byte[] to ByteBuffer, which should have positive impact on memoru consumption and hopefully performance too.
  • If not sufficient, think of precalculating checksums on background and persist calculated checksums somehow. Create another task for that.
@sparkoo sparkoo added the bug label Jul 21, 2017
@sparkoo sparkoo self-assigned this Jul 21, 2017
@sparkoo sparkoo mentioned this issue Jul 24, 2017
Merged
@sparkoo
Copy link
Owner Author

sparkoo commented Jul 25, 2017

memory consumption solved by #12
performance cost is still to high -> need to precalculate checksums #13
closing this

@sparkoo sparkoo closed this as completed Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sparkoo sparkoo

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sparkoo