Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for publish to npm #40

Closed
wants to merge 2 commits into from
Closed

Prepare for publish to npm #40

wants to merge 2 commits into from

Conversation

shaungrady
Copy link
Contributor

@shaungrady shaungrady commented Oct 22, 2016

Resolves #37

Few things to be aware of:

  • Capital letters are not permissible in the name field of the package, so I changed it to media-check.
  • Your script is not a CommonJS module, so it won't be easilyrequireable. If/when you do decide to make it CJS-compatible, it will have to be bundled for testing.
  • The files field in package.json defines what files are included when someone npm installs mediaCheck. The minified version is not included in the package, as this is discouraged by npm.

@robtarr Let me know if you have any questions. Otherwise, it's ready for merge and npm publish.

@robtarr
Copy link
Contributor

robtarr commented Oct 25, 2016

Yeah, I don't want to publish it to NPM before the work to convert it to a module is done. I'll open another issue for that if I can't get to it soon.

Thanks.

@shaungrady shaungrady closed this Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish latest version to npm
2 participants