Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space details to the stack object #201

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Add space details to the stack object #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion internal/cmd/stack/list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,13 @@ type stack struct {
State string `graphql:"state" json:"state,omitempty"`
StateSetAt int64 `graphql:"stateSetAt" json:"stateSetAt,omitempty"`
TerraformVersion string `graphql:"terraformVersion" json:"terraformVersion,omitempty"`
TrackedCommit struct {
SpaceDetails struct {
ID string `graphql:"id" json:"id,omitempty"`
Name string `graphql:"name" json:"name,omitempty"`
Description string `graphql:"description" json:"description,omitempty"`
ParentSpace *string `graphql:"parentSpace" json:"parentSpace,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In SpaceDetails we have both ID and Name. Is ParentSpace the id or name?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we resolve ParentSpace as a SpaceDetails struct?
In case someone has built deep space hierarchies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a thing by default, requires additional queries. By default it's just a string value, ID.

} `graphql:"spaceDetails" json:"spaceDetails,omitempty"`
TrackedCommit struct {
AuthorLogin string `graphql:"authorLogin" json:"authorLogin,omitempty"`
AuthorName string `graphql:"authorName" json:"authorName,omitempty"`
Hash string `graphql:"hash" json:"hash,omitempty"`
Expand Down