Add space details to the stack object #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tomasmik <[email protected]>
cube2222
approved these changes
Nov 17, 2023
mbialon
approved these changes
Nov 17, 2023
| ID string `graphql:"id" json:"id,omitempty"` | ||
| Name string `graphql:"name" json:"name,omitempty"` | ||
| Description string `graphql:"description" json:"description,omitempty"` | ||
| ParentSpace *string `graphql:"parentSpace" json:"parentSpace,omitempty"` |
There was a problem hiding this comment.
In SpaceDetails we have both ID and Name. Is ParentSpace the id or name?
| ID string `graphql:"id" json:"id,omitempty"` | ||
| Name string `graphql:"name" json:"name,omitempty"` | ||
| Description string `graphql:"description" json:"description,omitempty"` | ||
| ParentSpace *string `graphql:"parentSpace" json:"parentSpace,omitempty"` |
There was a problem hiding this comment.
Could we resolve ParentSpace as a SpaceDetails struct?
In case someone has built deep space hierarchies.
There was a problem hiding this comment.
Not a thing by default, requires additional queries. By default it's just a string value, ID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue requests to add filtering by space #198 I propose we add space to the output and callers can use
jq:Closes #198