-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG: Fix skipmer test test_manysketch_skipm2n3
now that sourmash is updated
#568
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
Wait... are the tests failing on the CI because they're using the released version of sourmash, which doesn't fully support skip-mers? So we need to release a new version of sourmash to get this to work? 😭 |
sigh, i think so. Also it needs sourmash-bio/sourmash#3457. The fixes I have there fix |
k - for now, I'm going to "fix" this by reverting to the old behavior, but with a comment. Then when it starts breaking again on the new sourmash release, will fix it again. Frustrating situation but no simple way around it 😅 |
axshually, I just did a terrible if/else so it will work for now w/latest dev version of sourmash as well as released version, and then break properly when we release a new version of sourmash. 🎉 see 92d634a. |
@bluegenes if you update to latest dev version of sourmash (as of right now ;)) then tests will pass here, as well as on CI. When we release a new version of sourmash, whether it be 4.8.13 or 4.9.0, this test will break again, and we can remove the if/else code then (and update the sourmash version requirement!) |
Fixes #565