Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: Fix skipmer test test_manysketch_skipm2n3 now that sourmash is updated #568

Merged
merged 7 commits into from
Jan 7, 2025

Conversation

ctb
Copy link
Collaborator

@ctb ctb commented Jan 4, 2025

Fixes #565

Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@ctb
Copy link
Collaborator Author

ctb commented Jan 5, 2025

Wait... are the tests failing on the CI because they're using the released version of sourmash, which doesn't fully support skip-mers? So we need to release a new version of sourmash to get this to work? 😭

@bluegenes
Copy link
Contributor

sigh, i think so. Also it needs sourmash-bio/sourmash#3457. The fixes I have there fix sig downsample, but I'm not sure they fix every issue, since I don't have comprehensive skipmer testing on the sig functions

@ctb
Copy link
Collaborator Author

ctb commented Jan 7, 2025

k - for now, I'm going to "fix" this by reverting to the old behavior, but with a comment. Then when it starts breaking again on the new sourmash release, will fix it again. Frustrating situation but no simple way around it 😅

@ctb
Copy link
Collaborator Author

ctb commented Jan 7, 2025

axshually, I just did a terrible if/else so it will work for now w/latest dev version of sourmash as well as released version, and then break properly when we release a new version of sourmash. 🎉

see 92d634a.

@ctb
Copy link
Collaborator Author

ctb commented Jan 7, 2025

@bluegenes if you update to latest dev version of sourmash (as of right now ;)) then tests will pass here, as well as on CI. When we release a new version of sourmash, whether it be 4.8.13 or 4.9.0, this test will break again, and we can remove the if/else code then (and update the sourmash version requirement!)

@ctb ctb merged commit 48bb1c9 into main Jan 7, 2025
3 checks passed
@ctb ctb deleted the fix_skip_test branch January 7, 2025 14:55
@ctb ctb mentioned this pull request Jan 15, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_sketch.py::test_manysketch_skipm2n3 is failing on main?
2 participants