Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_sketch.py::test_manysketch_skipm2n3 is failing on main? #565

Closed
ctb opened this issue Jan 3, 2025 · 2 comments · Fixed by #568
Closed

test_sketch.py::test_manysketch_skipm2n3 is failing on main? #565

ctb opened this issue Jan 3, 2025 · 2 comments · Fixed by #568

Comments

@ctb
Copy link
Collaborator

ctb commented Jan 3, 2025

src/python/tests/test_sketch.py::test_manysketch_skipm2n3

>       assert len(sigs) == 3  # 3 dna, 3 skipmer. But sourmash can only read the DNA sigs!!
E       AssertionError: assert 6 == 3
E        +  where 6 = len([SourmashSignature('short3', f85747ac), SourmashSignature('short3', 890557b3), SourmashSignature('short', 1474578c), SourmashSignature('short', 0486fcae), SourmashSignature('short2', 4efeebd2), SourmashSignature('short2', ec6305f5)])

not sure if it's my laptop, or what.

@bluegenes
Copy link
Contributor

Ah, this test assumed we could not read skipmer signatures with sourmash python layer. Needs to be updated now that we ~can.

@ctb
Copy link
Collaborator Author

ctb commented Jan 4, 2025

Fixed in #568

@ctb ctb closed this as completed in #568 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants