[LA.UM.7.1.r1] Cope with the non-existence of some of the config files #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g files In my testing I run into this, which wasn't caught properly: . . . Merging arch/arm64/configs/sony/android-extra.config The merge file 'arch/arm64/configs/sony/android-extra.config' does not exist. Exit
|
@pablomh These programs should terminate with a non-zero exit code, right? Any idea why we're capturing output here and not checking exit code instead? ie. afaik something like |
pablomh
changed the title
|
I'm just following the existing code style :/ I agree that it's ugly but didn't want to touch it that much. |
|
@pablomh No worries, I was just hoping if you could test and improve the situation :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my testing I run into this, which wasn't caught properly: