[9.12.r1] Add initial 4.19 defconfigs #88
Conversation
As of commit 0bfe64ee4b84484aa61a4b77cfe861d1a5f1c283 https://android.googlesource.com/kernel/configs/+/refs/heads/master/android-4.19 Signed-off-by: Konrad Dybcio <[email protected]>
konradybcio
force-pushed
the
aosp/LA.UM.9.12.r1
branch
from
89acff7 to
3af249d
Compare
Signed-off-by: Konrad Dybcio <[email protected]>
Signed-off-by: Konrad Dybcio <[email protected]>
Signed-off-by: Konrad Dybcio <[email protected]>
konradybcio
force-pushed
the
aosp/LA.UM.9.12.r1
branch
from
5a1c30c to
41b95a8
Compare
update-defconfig.sh
Outdated
| ${KERNEL_CFG}/android-recommended-arm64.config \ | ||
| ${KERNEL_CFG}/base_${SOC}_defconfig \ | ||
| ${KERNEL_CFG}/base_${platform}"_"${device}\_defconfig \ | ||
| ${KERNEL_CFG}/android-extra.config 2>&1); |
There was a problem hiding this comment.
This file is not included in the PR and we should decide where to get it from (4.14???).
the config files In my testing I run into this, which wasn't caught properly: . . . Merging arch/arm64/configs/sony/android-extra.config The merge file 'arch/arm64/configs/sony/android-extra.config' does not exist. Exit
Signed-off-by: Konrad Dybcio <[email protected]>
Google stopped shipping the gcc binary for GCC4.9 (for now?). Not setting the variable makes the script not fail. Signed-off-by: Konrad Dybcio <[email protected]>
Signed-off-by: Konrad Dybcio <[email protected]>
konradybcio
force-pushed
the
aosp/LA.UM.9.12.r1
branch
from
3ea1f04 to
5441e50
Compare
|
The options in |
Signed-off-by: Konrad Dybcio <[email protected]>
Signed-off-by: Konrad Dybcio <[email protected]>
Signed-off-by: Konrad Dybcio <[email protected]>
| CONFIG_LEDS_QPNP_FLASH_V2=y | ||
| CONFIG_LEDS_QTI_TRI_LED=y | ||
| CONFIG_LEDS_TRIGGER_TIMER=y | ||
| CONFIG_LOCALVERSION="-perf" |
There was a problem hiding this comment.
I don't think we use this on open devices?
| #export CROSS_COMPILE=prebuilts/gcc/linux-x86/aarch64/aarch64-linux-android-4.9/bin/aarch64-linux-android- | ||
| export BUILD="make O=$KERNEL_TMP ARCH=arm64 CROSS_COMPILE=$CROSS_COMPILE -j$(nproc)" |
There was a problem hiding this comment.
Might as well remove entirely? Or set to the compiler that is to be used by -prebuilts?
| @@ -0,0 +1,179 @@ | |||
| # KEEP ALPHABETICALLY SORTED | |||
There was a problem hiding this comment.
Iirc I asked this before, android-extra.config is not an "android" config (https://android.googlesource.com/kernel/configs/+/refs/tags/android-11.0.0_r28/r/android-4.19/) but something we as SODP add on top, shared by all devices.
Suggestion is to rename it to sony/sodp-base.config.
There was a problem hiding this comment.
I'd prefer base_sodp_defconfig or even better base_sodp.config (why do we append _defconfig to our files instead of the common .config?).
There was a problem hiding this comment.
@pablomh I don't mind either, as long as it is consistent 👌
The kernel uses <snake_case_target>_defconfig, AOSP uses <file>.config for the extra bits.
No description provided.