Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor, chore] 인터랙션 페이지 유저플로우에 맞게 수정 #94

Merged
merged 3 commits into from
Aug 13, 2024
Merged

[refactor, chore] 인터랙션 페이지 유저플로우에 맞게 수정 #94

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87aeaa2
[refactor] 유저플로우에 맞게 로직 수정, 리팩터링
darkdulgi Aug 13, 2024
3aa9a73
[fix] 레이아웃 수정
darkdulgi Aug 13, 2024
fc6b191
[chore] 날짜를 constants 내 상수로 사용하도록 함
darkdulgi Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/mainPage/features/interactions/description/InteractionSlide.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import InteractionModal from "../modal/InteractionModal";
import openModal from "@common/modal/openModal.js";
import { padNumber } from "@common/utils.js";
import { EVENT_START_DATE } from "@common/constants";

function getEventDate(index) {
const day = ["일", "월", "화", "수", "목", "금", "토"];
const fullDate = new Date(2024, 8, 9 + index);
const fullDate = new Date(EVENT_START_DATE.getTime() + index * 24 * 60 * 60 * 1000);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

24 * 60 * 60 * 1000은 매직 넘버이므로, 별도의 상수로 분리해 주세요.


const month = fullDate.getMonth() + 1;
const date = fullDate.getDate();
Expand Down