[refactor, chore] 인터랙션 페이지 유저플로우에 맞게 수정 #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lybell-art
reviewed
Aug 13, 2024
|
|
||
| function getEventDate(index) { | ||
| const day = ["일", "월", "화", "수", "목", "금", "토"]; | ||
| const fullDate = new Date(2024, 8, 9 + index); | ||
| const fullDate = new Date(EVENT_START_DATE.getTime() + index * 24 * 60 * 60 * 1000); |
There was a problem hiding this comment.
24 * 60 * 60 * 1000은 매직 넘버이므로, 별도의 상수로 분리해 주세요.
lybell-art
reviewed
Aug 13, 2024
| @@ -33,7 +34,6 @@ export default function InteractionAnswer({ | |||
| }) | |||
| .then((res) => { | |||
| console.log(res); | |||
| setIsJoined(true); | |||
| }) | |||
| .catch((e) => { | |||
| console.log(e); | |||
There was a problem hiding this comment.
향후 해당부분 기능 체크리스트에 저장해두었다가 나중에 추가해주시면 감사하겠습니다
lybell-art
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관 이슈
📝 작업 내용