Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add android-app scheme to valid scheme list #145

Closed

Conversation

scottbullard
Copy link

Addresses referer values such as: android-app://com.google.android.gm

#131

@scottbullard scottbullard changed the title Add android-app scheme to valid list valid Add android-app scheme to valid scheme list Apr 7, 2017
@snowplowcla
Copy link

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://github.com/snowplow/snowplow/wiki/CLA to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

@snowplowcla
Copy link

We will have to close this PR in 7 days unless the CLA can be signed.

@BenFradet
Copy link
Contributor

@scottbullard did you sign the cla in the end?

@dsingleton
Copy link

I've run into the same issue, would you be open to someone submitting the same change, but signing the CLA?

@alexanderdean
Copy link
Contributor

Hi @dsingleton - as long as you are duplicating the intent of this PR but not the literal code, it should be fine. Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants