Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Ruby) Allow 'android-app' URL scheme #178

Merged

Conversation

turino
Copy link
Contributor

@turino turino commented Feb 6, 2018

Referer urls like
"android-app://com.google.android.googlequicksearchbox" are valid and
shouldn't cause an error.

This is related to #172, and almost identical to #145 . I've signed the CLA, so I'm hoping we can get this merged. Let me know if you need me to do anything else.

@snowplowcla
Copy link

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://github.com/snowplow/snowplow/wiki/CLA to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

@turino
Copy link
Contributor Author

turino commented Feb 6, 2018

I signed it!

@turino
Copy link
Contributor Author

turino commented Feb 6, 2018

I had already signed when I submitted the PR. Does the CLA bot check before commenting/does that mean there's something wrong with how I signed?

@snowplowcla snowplowcla added cla:yes and removed cla:no labels Feb 8, 2018
@snowplowcla
Copy link

Confirmed! @turino has signed the Individual Contributor License Agreement. Thanks so much

@alexanderdean
Copy link
Contributor

Sorry @turino, the CLA-bot is quite temperamental...

@dsingleton
Copy link

This looks like it's ready to go? 🎉

I was following #145, and we're still having the same problem, it'd be great to get this fixed :)

@turino
Copy link
Contributor Author

turino commented Mar 8, 2018

@alexanderdean anything else I can do to help get this merged?

@alexanderdean alexanderdean requested a review from BenFradet March 8, 2018 23:22
@alexanderdean
Copy link
Contributor

Added @BenFradet to review...

Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 , sorry I missed it I was on hols when you opened the pr.

Could you rebase against develop, then I'll merge?

@BenFradet BenFradet changed the base branch from master to develop March 12, 2018 09:41
Referer urls like
"android-app://com.google.android.googlequicksearchbox" are valid and
shouldn't cause an error.
@turino turino force-pushed the jt-ruby-android-scheme branch from c86451d to d34ab2b Compare March 14, 2018 18:44
@turino
Copy link
Contributor Author

turino commented Mar 14, 2018

@BenFradet done!

@BenFradet BenFradet merged commit 37d8778 into snowplow-referer-parser:develop Mar 15, 2018
@BenFradet
Copy link
Contributor

Merged, thanks @turino 👍

@turino turino deleted the jt-ruby-android-scheme branch March 15, 2018 16:25
@turino
Copy link
Contributor Author

turino commented Mar 15, 2018

Thanks! When will we see a new version of the gem?

@BenFradet
Copy link
Contributor

We actually want to split this repo up by language in https://github.com/snowplow-referer-parser (I actually just created https://github.com/snowplow-referer-parser/ruby-referer-parser) to be more agile regarding releases.

I guess we won't be making releases until the above is done. Any help easing this process would be greatly appreciated 👍 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants