-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Ruby) Allow 'android-app' URL scheme #178
(Ruby) Allow 'android-app' URL scheme #178
Conversation
Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://github.com/snowplow/snowplow/wiki/CLA to learn more and sign. Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks. |
I signed it! |
I had already signed when I submitted the PR. Does the CLA bot check before commenting/does that mean there's something wrong with how I signed? |
Confirmed! @turino has signed the Individual Contributor License Agreement. Thanks so much |
Sorry @turino, the CLA-bot is quite temperamental... |
This looks like it's ready to go? 🎉 I was following #145, and we're still having the same problem, it'd be great to get this fixed :) |
@alexanderdean anything else I can do to help get this merged? |
Added @BenFradet to review... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍 , sorry I missed it I was on hols when you opened the pr.
Could you rebase against develop, then I'll merge?
Referer urls like "android-app://com.google.android.googlequicksearchbox" are valid and shouldn't cause an error.
c86451d
to
d34ab2b
Compare
@BenFradet done! |
Merged, thanks @turino 👍 |
Thanks! When will we see a new version of the gem? |
We actually want to split this repo up by language in https://github.com/snowplow-referer-parser (I actually just created https://github.com/snowplow-referer-parser/ruby-referer-parser) to be more agile regarding releases. I guess we won't be making releases until the above is done. Any help easing this process would be greatly appreciated 👍 . |
Referer urls like
"android-app://com.google.android.googlequicksearchbox" are valid and
shouldn't cause an error.
This is related to #172, and almost identical to #145 . I've signed the CLA, so I'm hoping we can get this merged. Let me know if you need me to do anything else.