-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Otterspace badges voting strategy #242
Draft
Orland0x
wants to merge
4
commits into
main
Choose a base branch
from
feat_otterspace_bades_strategy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule otterspace-contracts
added at
aec3d4
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
// SPDX-License-Identifier: MIT | ||
|
||
pragma solidity ^0.8.18; | ||
|
||
// import { Badges } from "@otterspace/contracts/Badges.sol"; | ||
import { IVotingStrategy } from "../interfaces/IVotingStrategy.sol"; | ||
|
||
interface IBadges { | ||
function ownerOf(uint256 tokenId) external view returns (address); | ||
} | ||
|
||
/// @title Otterspace Badge Voting Strategy | ||
/// @notice Allows Otterspace Badges to be used for voting power. | ||
contract OtterspaceBadgesVotingStrategy is IVotingStrategy { | ||
error InvalidBadge(); | ||
|
||
/// @notice The address of the Otterspace Badges Contract. | ||
address public badgesRegistry; | ||
|
||
/// @dev Data stored as parameters for each Badge. | ||
struct Badge { | ||
// spec of the badge. | ||
string specUri; | ||
// The voting power granted to badges of this spec. | ||
uint96 vp; | ||
} | ||
|
||
constructor(address BadgesRegistry) { | ||
badgesRegistry = BadgesRegistry; | ||
} | ||
|
||
/// @notice Returns the voting power of an address. | ||
/// @param voter The address to get the voting power of. | ||
/// @param params Parameter array containing the encoded whitelist of addresses and their voting power. | ||
/// The array should be an ABI encoded array of Member structs. | ||
/// @param userParams Parameter array containing an array of indices of | ||
/// @return votingPower The voting power of the address if it exists in the whitelist, otherwise reverts. | ||
function getVotingPower( | ||
uint32 /* blockNumber */, | ||
address voter, | ||
bytes calldata params, | ||
bytes calldata userParams | ||
) external view override returns (uint256 votingPower) { | ||
Badge[] memory badges = abi.decode(params, (Badge[])); | ||
uint8[] memory userBadgeIndices = abi.decode(userParams, (uint8[])); | ||
|
||
uint256 vp; | ||
for (uint8 i = 0; i < userBadgeIndices.length; i++) { | ||
uint256 tokenId = uint256(getBadgeIdHash(voter, badges[userBadgeIndices[i]].specUri)); | ||
if (IBadges(badgesRegistry).ownerOf(tokenId) != voter) revert InvalidBadge(); | ||
vp += badges[userBadgeIndices[i]].vp; | ||
} | ||
|
||
return vp; | ||
} | ||
|
||
/// @dev Generates the unique ID of a badge for a given address and spec. | ||
function getBadgeIdHash(address _to, string memory _uri) internal pure returns (bytes32) { | ||
return keccak256(abi.encode(_to, _uri)); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this required? Can't we just query with balanceOf or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i thought we wanted different voting power for different badges? that would just give a single balance of all badges the address owns.