feat: Otterspace badges voting strategy #242
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonustrack
reviewed
Sep 29, 2023
| /// @param voter The address to get the voting power of. | ||
| /// @param params Parameter array containing the encoded whitelist of addresses and their voting power. | ||
| /// The array should be an ABI encoded array of Member structs. | ||
| /// @param userParams Parameter array containing an array of indices of |
There was a problem hiding this comment.
Is this required? Can't we just query with balanceOf or something?
There was a problem hiding this comment.
i thought we wanted different voting power for different badges? that would just give a single balance of all badges the address owns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows variable voting power to be given to owners of badges identified by their spec.