Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter noise #199

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Fix linter noise #199

merged 1 commit into from
Jun 5, 2024

Conversation

northdpole
Copy link
Contributor

current linter setup is very noisy, also reviewdog's github integraton has a bug that double/tripple reports findings on removed code, however, when running locally, the linter works as expected, so we do the same for ci/cd

closes #198

…on has a bug that double/tripple reports findings on removed code, however, when running locally, the linter works as expected, so we do the same for ci/cd
@northdpole northdpole requested a review from ptzianos June 5, 2024 10:35
@northdpole northdpole merged commit 9721a8d into main Jun 5, 2024
3 checks passed
@northdpole northdpole deleted the fix-linting-noise branch June 5, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use reviewdog without the Github check plugin
2 participants