Skip to content

Commit

Permalink
current linter setup is very noisy, also reviewdog's github integrati…
Browse files Browse the repository at this point in the history
…on has a bug that double/tripple reports findings on removed code, however, when running locally, the linter works as expected, so we do the same for ci/cd
  • Loading branch information
northdpole committed Jun 5, 2024
1 parent faaf0fb commit 9721a8d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ clean: clean-protos clean-migrations-compose
.PHONY: lint install-lint-tools tests go-tests fmt fmt-proto fmt-go install-go-fmt-tools migration-tests

lint:
@reviewdog -fail-on-error $$([ "${CI}" = "true" ] && echo "-reporter=github-pr-review") -diff="git diff origin/main" -filter-mode=added -tee
@reviewdog -fail-on-error -diff="git diff origin/main" -filter-mode=added -tee

install-lint-tools:
@go install honnef.co/go/tools/cmd/staticcheck@latest
Expand Down

0 comments on commit 9721a8d

Please sign in to comment.