GO-124 Fix removing SignatureRequested Tag from MessageThread

app/models/message_object.rb

@@ -157,6 +157,7 @@ def remove_object_related_tags_from_thread
     end
 
     message.thread.unassign_tag(message.tenant.signed_tag!) unless message.thread.tags.reload.where(type: SignedByTag.to_s).any?
+    message.thread.unassign_tag(message.tenant.signature_requested_tag!) unless message.thread.tags.reload.where(type: SignatureRequestedFromTag.to_s).any?
   end
 
   def other_thread_objects_include_tag?(tag)

db/migrate/20240820143244_remove_extra_signature_tags.rb

@@ -0,0 +1,8 @@
+class RemoveExtraSignatureTags < ActiveRecord::Migration[7.1]
+  def up
+    MessageThread.find_each do |message_thread|
+      message_thread.unassign_tag(message_thread.tenant.signature_requested_tag!) unless message_thread.tags.reload.where(type: SignatureRequestedFromTag.to_s).any?
+      message_thread.unassign_tag(message_thread.tenant.signed_tag!) unless message_thread.tags.reload.where(type: SignedByTag.to_s).any?
+    end
+  end
+end

test/models/message_object_test.rb

@@ -188,7 +188,7 @@ class MessageObjectTest < ActiveSupport::TestCase
                  object_1.message.thread.tags.signing_tags.reload.to_set
   end
 
-  test "before_destroy callback deletes object related tags from message thread after object removal (if no more objects with the tag present)" do
+  test "before_destroy callback deletes object related tags from message thread (if no more objects with the tag present)" do
     tenant = tenants(:ssd)
     signer = users(:basic_two)
     signed_by_tag = tags(:ssd_basic_user_signed)
@@ -206,7 +206,7 @@ class MessageObjectTest < ActiveSupport::TestCase
     assert_not object.message.thread.tags.include?(tenant.signed_tag!)
   end
 
-  test "before_destroy callback keeps object related tags for message thread after object removal (if another objects with the tag present in the message)" do
+  test "before_destroy callback keeps object related tags for message thread (if another objects with the tag present in the message)" do
     tenant = tenants(:ssd)
     signer = users(:basic_two)
     signed_by_tag = tags(:ssd_basic_user_signed)
@@ -230,7 +230,7 @@ class MessageObjectTest < ActiveSupport::TestCase
     assert attachment_object.message.thread.tags.include?(tenant.signed_tag!)
   end
 
-  test "before_destroy callback keeps object related tags for message thread after object removal (if objects with the tag present in another message in the thread)" do
+  test "before_destroy callback keeps object related tags for message thread (if objects with the tag present in another message in the thread)" do
     tenant = tenants(:ssd)
     signer = users(:basic_two)
     signed_by_tag = tags(:ssd_basic_user_signed)
@@ -254,6 +254,17 @@ class MessageObjectTest < ActiveSupport::TestCase
     assert attachment_object.message.thread.tags.include?(tenant.signed_tag!)
   end
 
+  test "before_destroy callback deletes SignatureRequested tag from message thread (if no more objects with requested signature present in the thread)" do
+    signature_requested_tag = tags(:ssd_signature_requested)
+    form_object = message_objects(:ssd_main_draft_to_be_signed4_draft_form)
+
+    assert form_object.message.thread.tags.include?(signature_requested_tag)
+
+    form_object.destroy
+
+    assert_not form_object.message.thread.tags.reload.include?(signature_requested_tag)
+  end
+
   test "prepares PDF visualization" do
     message_object = message_objects(:ssd_main_fs_one_form)