Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GO-124 Fix removing SignatureRequested Tag from MessageThread #466

Merged

Conversation

luciajanikova
Copy link
Member

No description provided.

@luciajanikova luciajanikova requested a review from jsuchal August 20, 2024 13:09
@jsuchal
Copy link
Member

jsuchal commented Aug 29, 2024

Tomuto uplne nerozumiem. Co toto riesi? Na taketo onetime fixy mozeme aj cez konzolu ci?

@luciajanikova
Copy link
Member Author

Nie je to iba onetime fix, upravuje to aj logiku tejto metody:

def remove_object_related_tags_from_thread
tags.each do |tag|
message.thread.unassign_tag(tag) unless other_thread_objects_include_tag?(tag)
end
message.thread.unassign_tag(message.tenant.signed_tag!) unless message.thread.tags.reload.where(type: SignedByTag.to_s).any?
message.thread.unassign_tag(message.tenant.signature_requested_tag!) unless message.thread.tags.reload.where(type: SignatureRequestedFromTag.to_s).any?
end

@luciajanikova luciajanikova merged commit a8aef92 into main Sep 3, 2024
@luciajanikova luciajanikova deleted the GO-124/handle_removing_signature_requested_tag_from_thread branch September 3, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants