Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer optional and formatted values in the "Create issue" form #47

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Prefer optional and formatted values in the "Create issue" form #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f33ad7e
use the url format for the repo url
zimeg Oct 30, 2023
a35931e
do not require optional inputs
zimeg Oct 30, 2023
d49e6d7
merge w main
zimeg Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions functions/create_issue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ export const CreateIssueDefinition = DefineFunction({
"githubAccessTokenId",
"url",
"title",
"description",
"assignees",
],
},
output_parameters: {
Expand Down
3 changes: 2 additions & 1 deletion workflows/create_new_issue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ const issueFormData = CreateNewIssueWorkflow.addStep(
title: "Repository URL",
description: "The GitHub URL of the repository",
type: Schema.types.string,
format: "url",
}, {
name: "title",
title: "Issue title",
Expand All @@ -61,7 +62,7 @@ const issueFormData = CreateNewIssueWorkflow.addStep(
"GitHub username(s) of the user(s) to assign the issue to (separated by commas)",
type: Schema.types.string,
}],
required: ["url", "title", "description", "assignees"],
required: ["url", "title"],
},
},
);
Expand Down