Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer optional and formatted values in the "Create issue" form #47

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Oct 30, 2023

Type of change

  • New sample
  • New feature
  • Bug fix
  • Documentation

Summary

This PR adds the url format to the "Create issue" form and no longer requires the description and assignee values since these are optional for the API.

Reviewers

Either test this updated workflow or confirm this created issue looks good – zimeg/slack-sandbox#49.

Note: The optional fields were previously reverted due to #18 but this seems to be fixed now!

Requirements

  • I’ve checked my submission against the Samples Checklist to ensure it complies with all standards
  • I have ensured the changes I am contributing align with existing patterns and have tested and linted my code
  • I've read and agree to the Code of Conduct

@zimeg zimeg added the enhancement New feature or request label Oct 30, 2023
@zimeg zimeg self-assigned this Oct 30, 2023
@zimeg
Copy link
Member Author

zimeg commented Oct 31, 2023

🙇 appreciate the review greatly @filmaj

@zimeg zimeg merged commit 766ed8b into main Oct 31, 2023
2 checks passed
@zimeg zimeg deleted the formed-values branch October 31, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants