Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Show non common GPUs by default when querying specific clouds #3925

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions sky/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -3180,20 +3180,29 @@ def _output():
yield '\n\n'
yield from tpu_table.get_string()

# Other GPUs
if show_all:
# Handle Other GPUs
if show_all or cloud is not None:
yield '\n\n'
for gpu, qty in sorted(result.items()):
other_table.add_row([gpu, _list_to_str(qty)])
yield from other_table.get_string()
yield '\n\n'
else:
yield ('\n\nHint: use -a/--all to see all accelerators '
'(including non-common ones) and pricing.')
if k8s_messages:
yield '\n'
yield k8s_messages
return

# Handle hints and messages
if not show_all:
if cloud is None:
yield ('\n\nHint: use -a/--all to see all accelerators '
'(including non-common ones) and pricing.')
# Handle k8 messages if present
if k8s_messages:
yield '\n'
yield k8s_messages
return
else:
# Return if not showing all or a specific cloud was queried
yield ('Hint: use -a/--all to see all accelerators '
'and pricing.')
return
else:
# Parse accelerator string
accelerator_split = accelerator_str.split(':')
Expand Down
Loading