FIX: Show non common GPUs by default when querying specific clouds #3925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @wizenheimer. I think the desired behavior is to print only |
|
Hey @romilbhardwaj, Current Change Others (consistent with master) |
There was a problem hiding this comment.
Thanks for the great work @wizenheimer! Tried it out and left some comments.
sky/cli.py
Outdated
Comment on lines
3196
to
3199
| # Handle k8 messages if present | ||
| if k8s_messages: | ||
| yield '\n' | ||
| yield k8s_messages |
There was a problem hiding this comment.
We want to keep this under the if block above, else k8s_messages are printed twice when sky show-gpus -a is run.
sky/provision/__init__.py
Outdated
| @@ -186,12 +186,12 @@ def get_cluster_info( | |||
| def get_command_runners( | |||
| provider_name: str, | |||
| cluster_info: common.ClusterInfo, | |||
| **crednetials: Dict[str, Any], | |||
| **credentials: Dict[str, Any], | |||
There was a problem hiding this comment.
Thanks for fixing this in #3924 :) perhaps this branch needs to rebased/merged with latest?
sky/cli.py
Outdated
| else: | ||
|
|
||
| # Handle hints and messages | ||
| if not show_all and cloud is None: |
There was a problem hiding this comment.
We may need to do some special handling here. Refer to the master branch output and output in this branch below.
- We want to retain the hint at the end, but exclude the
(including non-common ones)bit. I.e., we should print a hint likeHint: use -a/--all to see all accelerators and pricing.whensky show-gpus --cloud xyzis run, and the current hintHint: use -a/--all to see all accelerators (including non-common ones) and pricing.whensky show-gpusis run. - There's some extra empty lines at the end of this branch's output.
Master:
(base) ➜ ~ sky show-gpus --cloud aws
COMMON_GPU AVAILABLE_QUANTITIES
A10G 1, 4, 8
A100 8
A100-80GB 8
H100 8
K80 1, 8, 16
L4 1, 4, 8
M60 1, 2, 4
T4 1, 4, 8
V100 1, 4, 8
V100-32GB 8
Hint: use -a/--all to see all accelerators (including non-common ones) and pricing.
This branch:
(base) ➜ ~ sky show-gpus --cloud aws
COMMON_GPU AVAILABLE_QUANTITIES
A10G 1, 4, 8
A100 8
A100-80GB 8
H100 8
K80 1, 8, 16
L4 1, 4, 8
M60 1, 2, 4
T4 1, 4, 8
V100 1, 4, 8
V100-32GB 8
OTHER_GPU AVAILABLE_QUANTITIES
Gaudi HL-205 8
L40S 1, 4, 8
Radeon Pro V520 1, 2, 4
T4g 1, 2
|
Thanks @romilbhardwaj, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Addressed
Changes Made
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_nameconda deactivate; bash -i tests/backward_compatibility_tests.shBefore
After