Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Media Buttons: Increase Completely rounded value #1148

Conversation

AlexGStapleton
Copy link
Member

Resolve #1147

@AlexGStapleton AlexGStapleton self-assigned this Sep 11, 2020
@Misplon
Copy link
Member

Misplon commented Sep 12, 2020

At the moment, this change doesn't seem to be working for me. I've tried inserting a new widget. Same issue.

Front_Page_–_SiteOrigin

@AlexGStapleton
Copy link
Member Author

I'm having trouble replicating this after making this change. Can you please show me a screenshot of your settings? There's a bunch of setting combinations and I feel like I've tried them all but I must have missed one.

@Misplon
Copy link
Member

Misplon commented Sep 12, 2020

I'm adding Facebook without changing any defaults. I'm then scrolling down and setting Completely rounded, I'm not changing anything else.

@AlexGStapleton
Copy link
Member Author

So the only way to really fix that is to adjust the width. The problem with doing that is that the required width is closer to Normal Padding. Medium Padding looks worse. We have two ways of proceeding:

  1. Remove the predefined fields and use number fields (migration code will be added to prevent any noticeable changes). This will allow for the user to manually size/round/pad the icons.
  2. Come up with new padding and width sizing.

The latter will remove the need for migration code and keep the widget relatively the same. The problem however is that there are going to be some different sized icons. An icon that's wide is going to require different values to an icon that's tall. The first route won't really avoid that but it will allow the user to find setting values they're happy with.

@Misplon
Copy link
Member

Misplon commented Sep 12, 2020

Thanks. I'll take a look over this tomorrow and get back to you.

@Misplon Misplon deleted the social-media-buttons-increase-completely-rounding branch September 21, 2020 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Social Media Buttons: Ensure Completely Rounded is working
2 participants