Social Network Buttons: Add dedicated icon/padding/margin fields #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Margin was ommited due to how reliant it is on the alignment setting.
|
I've added a FB network without changing any default settings:
When I switch to this branch, the effect is:
|
Misplon
reviewed
Sep 25, 2020
|
We need to come up with some new default settings. |
|
The new defaults should ideally be px based to avoid inconsistent sizing between sites. The migration code will migrate the previously selected settings and retain em so there's no need to stick with em for the new defaults. |
|
Removed rounding changes. We'll come up with values that work better in a future PR. |
AlexGStapleton
changed the title
|
I'm going to close this PR for the time being. While removing Rounding did make this PR much simpler overall, there are still some complications with margins still make it a tricky change. We may pick this back up later based on community feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1147
Background to change