Add Eve Room 2 Support #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR. At the moment I’m on holiday and cannot check it, nor publish on NPM. Could you update also the readme in the meantime? |
|
@simont77 good call! Will add this. |
sieren
force-pushed
the
add-room2-support
branch
from
f470fe9 to
e49b4eb
Compare
|
@simont77 force pushed a README update to the initial commit. |
|
Example running an Aqara TVOC Sensor via homebridge-hue:
|
sieren
force-pushed
the
add-room2-support
branch
4 times, most recently
from
fcc3aaf to
fdc6554
Compare
|
Are you ok with this PR or you need more testing? |
|
@simont77 it seems to look good now. I realised during long-term testing that VOC values need to be integers, not floats and the averaging by the timer would introduce floats, so I added a fix for that on tuesday specifically for VOC. |
|
Actually hold off, this is missing in the README. |
Add support for Eve Room 2 using its characteristics and different data stream. Room 2 accepts VOC in ug/m3, though the app displays these values as ppb (ug/m3 * 4.57 = ppb).
sieren
force-pushed
the
add-room2-support
branch
from
fdc6554 to
2b7ad05
Compare
|
Okay, we're good now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Eve Room 2 using its characteristics
and different data stream.
The API accepts VOC in ug/m3, though the Eve app displays these
values as ppb (ug/m3 * 4.57 = ppb).
See: #107
Tested with
homebridge-hue(See ebaauw/homebridge-hue#1020)