-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Aqara TVOC Sensor Support #1020
Conversation
f2eede2
to
ea2e302
Compare
Haven't looked into that one before. Note that Eve is very picky on the accessory, services, and characteristics and won't display the history, unless it finds everything it's looking for. Note that Homebridge Hue still uses the
I would expect ppm to be ppb divided by 1,000 (1,000 parts per billion would be 1 part per million). However, with the reported value of 9, that would be 0.009. Not sure what you mean by offset of 450ppm.
You would need access to the device, and use HMCatalog to check the services, characteristics, and history parameters. It's a nice device, but a bit too expensive for my taste. I won't be buying the current version; maybe if the next, if it supports Thread.
Why on Earth did they expose |
Ah good to know. I noticed it was using fakegato.
I believe everything below 450ppm was considered "UNKNOWN" in terms of Air Quality in the Eve Room v1.
I actually own this device. The key difference to Room v1 isn't just the characteristics, but the different data-stream for Logging. AFAIK there is no support for this in Fakegato-History just yet (e.g. simont77/fakegato-history#107 ) and this needs to be reverse-engineered.
Good question indeed. |
Yeah, see: simont77/fakegato-history#75.
The Eve Room 2 likely uses a different data type in the history entries than the first-gen Eve Room. I've seen the same for the Eve Energy. |
ea2e302
to
a9624de
Compare
@ebaauw I managed to get it up and running with complete Fakegato support after quite a bit of trial and error. |
0703df1
to
615314f
Compare
@ebaauw this is ready for review now as my PR for Eve Room 2 support has been merged into fakegato-history and is live. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good functionally. Some remarks on the code style; please run standard
and fix the findings.
Do I understand correctly that the history entry only needs voc
(and computes the quality from that), but the Air Quality Sensor service needs both VOC Density and Air Quality characteristics? And the air quality is already reported by the device/computed by deCONZ?
Sounds good, I'll add these changes asap. Sorry for the semicolon slipups, my C++ background sometimes comes through ;) As for future-proofing this for other sensors, what do you suggest is the best approach here? Maintaining an array and using |
c07a96e
to
7fe31e1
Compare
Like homebridge-hue/lib/HueSensor.js Line 237 in b4cd70e
Create a variable homebridge-hue/lib/HueSensor.js Line 974 in b4cd70e
homebridge-hue/lib/HueSensor.js Line 1080 in b4cd70e
|
36d6dec
to
6949e06
Compare
Thanks @ebaauw , mind taking another look? |
Add Aqara TVOC Sensor support and support for Eve's history.
6949e06
to
3b97fe3
Compare
Thanks! I'll move the definition of the air quality map out of the routine, but otherwise looking great. |
Add ZHAAirQuality and CLIPAIrQuality, see PR #1020.
@sieren, could you please have a quick check that my change didn't break anything. I don't have a room-2-like sensor to test myself. |
@ebaauw been using homebridge master in a different home with a second aqara sensor for the past few hours and it's all working fine. 👌 |
Hi guys, i have add my aqara tvoc sensor to the z2m but the homebridge give alweays this error, `28/07/2022 23:49:54] [homebridge-z2m] Loaded homebridge-z2m v1.9.0 child bridge successfully [28/07/2022, 23:49:55] Loaded 0 cached accessories from cachedAccessories.0E79B1B83CF4. [28/07/2022, 23:49:55] [homebridge-z2m] Incorrect configuration: Entry for device is not correct: {"exclude":false,"converters":{"switch":{"type":"switch"},"occupancy":{"type":"occupancy"}}} [28/07/2022, 23:49:55] [homebridge-z2m] INVALID CONFIGURATION FOR PLUGIN: homebridge-z2m This plugin will NOT WORK until this problem is resolved. [28/07/2022, 23:49:55] Homebridge v1.5.0 (HAP v0.10.2) (homebridge-z2m) is running on port 53093 Can you guys help me? |
This PR introduces initial support for the Aqara TVOC Sensor which is ready to be merged into deCONZ (see dresden-elektronik/deconz-rest-plugin#4704 & dresden-elektronik/deconz-rest-plugin#5213)
Added additional support for Eve Room 2 (VOC/PPB) here: simont77/fakegato-history#114 which needs a merge + a version update prior to this PR.
Here's the API Output for this sensor: