Plan Basic UI #674
Merged
Plan Basic UI #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
davidmoore1
commented
Aug 21, 2024
•
davidmoore1
commented
- Make sure all necessary files are copied to the PWA from SAB
- Create an entry in the slide drawer that takes you to a Plans route
- Design for plan page that can contain 1, 2 or 3 tabs (for "My Plans", "Choose Plan", "Completed Plans" (note: completed plans is not handled in this issue)
- Display a list of all plans in the choose plan tab of the plans page
- Display plan detail page for an available plan that displays two tabs, the plan information tab and the plan calendar tab
- data for the plan (planConfig and planData)
- Tabs
- Icons for the tabs
- styling issue: width
- A plan information tab that will allow the plan to be opened or continued
- Image, title, duration, description
- Start plan button
- A plan calendar tab that displays a day-by-day list of the references for that day
- Day tabs with the references for each
- Fix styling of day tabs:
- Test multiple references in a day
- Checkboxes
- References can link to scripture (if it’s a started plan)
- Back arrow (going to either my plans or choose plans based on the state)
- Tab is initially positioned to the current entry (if started)
- A "My Plans" page that shows all open plans. (needs to keep track of the state of the plan)
- Ui
- Plan state
- Display a plan detail page for an open plan that shows the plan information tab, the plan calendar tab, and the plan settings tab
- The plan settings tab will be limited to just a "Plan Close" at this point from an open plan and limited to a "Setup Completed" with a continue button when starting a plan.
davidmoore1
force-pushed
the
feature/plan-basic-ui
branch
2 times, most recently
from
3475084 to
d9109d8
Compare
- added plans to the sidebar - still need an icon - tried to do the routing for plans, but I don't quite understand what I'm doing, so it's rusty, but it seems to navigate from the sidebar?
done/started:
- routing that takes you to the plan detail page
when you click on a plan (only works with the
plans under the choose plan tab - needs work)
- initial set up of the plan detail page with
two tabs: info and calendar
- display data/ui for the info tab
- display data/ui for the calendar tab
- in calendar, clicking on a day will display
the refs for that day
note: the detail page was designed with the
assumptiion that it's an unstarted plan
to do/needs work:
- databses and related issues
- json is only showing the first word of a string
- icons for the tabs in the detail page
- checkbox image for references under the calendar
- styling:
- width isn't right
- especially noticed on the calendar tab, the
css styles are not being found/applied
(I also added some css styles that were from
the inspection of the android to test some
things, and that should be taken out)
- there are no examples with multiple refs in a
day, so I'm not 100% sure that part of the code
works as it was untestable
- changed the <input> to <div> to allow for icons - created an InfoIcon for the info tab - used CalendarMonthIcon for the calendar tab note: it seems that the color of the icons is not being styled correctly
Included changes to convertStyles to add styles that have not been sent to PWA from SAB yet for plans
…roper locations based on the plan being active or not
…rence by checking for first reference for day that is not completed
davidmoore1
force-pushed
the
feature/plan-basic-ui
branch
from
dcd9db1 to
c5bbc7d
Compare
…before going to reference.
chrisvire
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.