Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plan basic UI #660

Closed
wants to merge 4 commits into from
Closed

plan basic UI #660

wants to merge 4 commits into from

Conversation

mikaylahubbard
Copy link
Contributor

@mikaylahubbard mikaylahubbard commented Aug 9, 2024 •
edited
Loading

  • Make sure all necessary files are copied to the PWA from SAB
  • Create an entry in the slide drawer that takes you to a Plans route
  • Design for plan page that can contain 1, 2 or 3 tabs (for "My Plans", "Choose Plan", "Completed Plans" (note: completed plans is not handled in this issue)
  • Display a list of all plans in the choose plan tab of the plans page
  • Display plan detail page for an available plan that displays two tabs, the plan information tab and the plan calendar tab
    • data for the plan (planConfig and planData)
    • Tabs
    • Icons for the tabs
    • styling issue: width
      Tab content is covered below - it is not fully completed
  • A plan information tab that will allow the plan to be opened or continued - STARTED (ui is there. Needs functionality)
    • Image, title, duration, description
    • Start plan button (there, but it needs functionality)
  • A plan calendar tab that displays a day-by-day list of the references for that day
    • Day tabs with the references for each
    • Fix styling of day tabs:
      CSS styles are not being found/applied?
      (I also added some CSS styles that were from
      the inspection of the android to test some
      things and that should be taken out)
    • Test multiple references in a day - there are no examples with multiple refs in a
      day, so I'm not 100% sure that part of the code works
    • Checkboxes (making them work is another issue)
    • References can link to scripture (if it’s a started plan)
    • Back arrow (going to either my plans or choose plans based on the state)
    • Tab is initially positioned to the current entry (if started)
  • A "My Plans" page that shows all open plans. (needs to keep track of the state of the plan. the ui is there, but for now, I’ve been sending in a plan, hardcoded in +page.js, for testing purposes as the functionality for having started and available plans needs work)
    • Ui
    • Plan state
  • Display a plan detail page for an open plan that shows the plan information tab, the plan calendar tab, and the plan settings tab
  • The plan settings tab will be limited to just a "Plan Close" at this point

@chrisvire chrisvire force-pushed the feature/plan-basic-ui branch from be5f00f to 0aa3eb7 Compare August 12, 2024 17:35
@mikaylahubbard @davidmoore1
start routing and sidebar for plans
65d1531 
- added plans to the sidebar - still need an icon
- tried to do the routing for plans, but I don't
quite understand what I'm doing, so it's rusty,
but it seems to navigate from the sidebar?
@mikaylahubbard @davidmoore1
Add plan icon
c06e790
@mikaylahubbard @davidmoore1
begin plans views: plan selection and plan detail
f5d9bab 
done/started:
- routing that takes you to the plan detail page
 when you click on a plan (only works with the
 plans under the choose plan tab - needs work)
 - initial set up of the plan detail page with
 two tabs: info and calendar
 - display data/ui for the info tab
 - display data/ui for the calendar tab
 - in calendar, clicking on a day will display
 the refs for that day
 note: the detail page was designed with the
 assumptiion that it's an unstarted plan

to do/needs work:
- databses and related issues
- json is only showing the first word of a string
- icons for the tabs in the detail page
- checkbox image for references under the calendar
- styling:
    - width isn't right
    - especially noticed on the calendar tab, the
    css styles are not being found/applied
    (I also added some css styles that were from
    the inspection of the android to test some
    things, and that should be taken out)
- there are no examples with multiple refs in a
day, so I'm not 100% sure that part of the code
works as it was untestable
@mikaylahubbard @davidmoore1
add icons to the tabs on the plan detail page
d9260cd 
- changed the <input> to <div> to allow for icons
- created an InfoIcon for the info tab
- used CalendarMonthIcon for the calendar tab

note: it seems that the color of the icons is
not being styled correctly
@davidmoore1 davidmoore1 force-pushed the feature/plan-basic-ui branch from 0377c0c to d9260cd Compare August 21, 2024 20:44
@davidmoore1
Copy link
Contributor

This PR has been replaced by PR #674

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikaylahubbard @davidmoore1