-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port TreeView to use redux-toolkit #2774
Conversation
Codecov ReportAttention:
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 10 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: 9 of 10 files reviewed, 2 unresolved discussions (waiting on @imnasnainaec)
src/components/TreeView/Redux/TreeViewActions.ts
line 25 at r2 (raw file):
export function resetTree(): Action { return resetAction();
Change to resetTreeAction. (and in TreeViewReducers.ts
)
Code quote:
resetAction
src/components/TreeView/Redux/TreeViewReducer.ts
line 16 at r2 (raw file):
setDomainLanguageAction: (state, action) => { state.currentDomain.lang = action.payload; state.language = action.payload;
What is the benefit of keeping the semantic domain language as a separate field in the redux state? It is available in the currentDomain
and there are several lines of code devoted to keeping them in sync.
Code quote:
state.language = action.payload;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 6 of 10 files reviewed, all discussions resolved (waiting on @imnasnainaec and @jmgrady)
src/components/TreeView/Redux/TreeViewReducer.ts
line 16 at r2 (raw file):
Previously, jmgrady (Jim Grady) wrote…
What is the benefit of keeping the semantic domain language as a separate field in the redux state? It is available in the
currentDomain
and there are several lines of code devoted to keeping them in sync.
I'd like to save this refactor for when we handle custom domains.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 10 files at r1, 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Part of #1953
This change is