Redux state is being set directly rather than by Redux

[jmgrady]

Describe the bug

Elements of the Redux state variable are being set outside of reducer that handles dispatched actions.

To Reproduce

Steps to reproduce the behavior:

1. Open ./src/store.ts.
2. In the call to configureStore, change the value of the immutableCheck property for the default middleware to true.
3. Run npm start to rebuild as a development build and start the application.
4. In the web browser that is opened:
   1. Open the browser debugging tools
   2. Log in to The Combine and open a project
   3. Click Review Entries
   4. An error message is displayed on the console explaining where the error is found.
5. Repeat for other combine operations, e.g. Data Entry, Merge Duplicates, etc.

Expected behavior

No errors reported.

Environment:

• OS: Ubuntu 22.04
• Browser Version: Brave Version 1.49.120 Chromium: 111.0.5563.64 (Official Build) (64-bit)

Redux reducers to be ported:

• loginReducer (Port Login to use redux-toolkit #2748)
• createProjectReducer (Port ExportProject to use redux-toolkit; Remove redux from CreateProject #2747)
• projectReducer (Port Project to use redux-toolkit #2754)
• exportProjectReducer (Port ExportProject to use redux-toolkit; Remove redux from CreateProject #2747)
• treeViewReducer (Port TreeView to use redux-toolkit #2774)
• reviewEntriesReducer (Port ReviewEntries to use redux-toolkit #2800)
• pronunciationsReducer (Port Pronunciations to use redux-toolkit #2753)
• goalsReducer (Update GoalTimeline component to use redux toolkit #2465)
• mergeDupStepReducer (Port MergeDups goal to use redux-toolkit #2704)
• characterInventoryReducer (Port CharInv goal to use redux-toolkit  #2749)
• analyticsReducer (Port analytics to use redux-toolkit #2782)
• Always run immutableCheck in development (Port ReviewEntries to use redux-toolkit #2800)
  • Change immutableCheckConfig in ./src/store.ts to something like:

    const immutableCheckConfig =
      process.env.NODE_ENV === "development" ? { warnAfter: 1000 } : false;
    

[jmgrady]

May be related to #1939

[jmgrady]

See the section on Immutability in the Redux Essentials tutorial. The state must never be updated directly; rather, a copy must be made, updated, and returned by the reducer functions.