Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataCleanup] Implement changes, completed for ReviewEntries #2743

Merged
merged 12 commits into from
Nov 30, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Oct 25, 2023

Used WordCard from #2715

Resolves #1247


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Oct 25, 2023
@imnasnainaec imnasnainaec changed the title Goal history ReviewEntries [DataCleanup] Implement changes, completed for ReviewEntries Oct 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

Attention: 92 lines in your changes are missing coverage. Please review.

Comparison is base (fcb36da) 72.70% compared to head (33ad76c) 72.37%.

Files Patch % Lines
src/goals/ReviewEntries/ReviewEntriesCompleted.tsx 0.00% 23 Missing ⚠️
src/components/WordCard/DomainChip.tsx 0.00% 16 Missing ⚠️
src/components/Buttons/UndoButton.tsx 0.00% 13 Missing ⚠️
src/components/GoalTimeline/Redux/GoalReducer.ts 0.00% 12 Missing ⚠️
src/components/WordCard/index.tsx 72.22% 3 Missing and 2 partials ⚠️
src/components/WordCard/SummarySenseCard.tsx 69.23% 4 Missing ⚠️
src/goals/MergeDuplicates/MergeDupsCompleted.tsx 0.00% 4 Missing ⚠️
...y/DataEntryTable/EntryCellComponents/EntryNote.tsx 25.00% 3 Missing ⚠️
src/goals/DefaultGoal/BaseGoalScreen.tsx 40.00% 3 Missing ⚠️
src/components/GoalTimeline/Redux/GoalActions.ts 0.00% 2 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2743      +/-   ##
==========================================
- Coverage   72.70%   72.37%   -0.34%     
==========================================
  Files         247      253       +6     
  Lines        9344     9469     +125     
  Branches     1077     1093      +16     
==========================================
+ Hits         6794     6853      +59     
- Misses       2225     2288      +63     
- Partials      325      328       +3     
Flag Coverage Δ
backend 82.87% <100.00%> (+0.03%) ⬆️
frontend 62.68% <45.56%> (-0.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec marked this pull request as ready for review November 17, 2023 21:56
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 75 of 75 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)


src/utilities/utilities.ts line 75 at r1 (raw file):

  const dateString = strs.slice(0, 3).join(sep?.date ?? pathSep.date);
  const timeString = strs.slice(3, 6).join(sep?.time ?? pathSep.time);
  return `${dateString}${sep?.dateTime ?? pathSep.dateTime}${timeString}`;

We should revisit this, date and time have interesting localization concerns


src/goals/ReviewEntries/ReviewEntriesTypes.ts line 136 at r1 (raw file):

/** Reverse map of the ReviewEntriesWord constructor.
 * Important: Not everything is preserved! */

maybe add an example of what isn't?

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 9294a04 into master Nov 30, 2023
17 checks passed
@imnasnainaec imnasnainaec deleted the goal-history-review-entries branch November 30, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants