-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataCleanup] Implement changes, completed for ReviewEntries #2743
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2743 +/- ##
==========================================
- Coverage 72.70% 72.37% -0.34%
==========================================
Files 247 253 +6
Lines 9344 9469 +125
Branches 1077 1093 +16
==========================================
+ Hits 6794 6853 +59
- Misses 2225 2288 +63
- Partials 325 328 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e28e452
to
508c4e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 75 of 75 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
src/utilities/utilities.ts
line 75 at r1 (raw file):
const dateString = strs.slice(0, 3).join(sep?.date ?? pathSep.date); const timeString = strs.slice(3, 6).join(sep?.time ?? pathSep.time); return `${dateString}${sep?.dateTime ?? pathSep.dateTime}${timeString}`;
We should revisit this, date and time have interesting localization concerns
src/goals/ReviewEntries/ReviewEntriesTypes.ts
line 136 at r1 (raw file):
/** Reverse map of the ReviewEntriesWord constructor. * Important: Not everything is preserved! */
maybe add an example of what isn't?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Used
WordCard
from #2715Resolves #1247
This change is