-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update local and refresh providers guide #641
Conversation
Hi @MuhammadM1998 👋 Thanks for updating the docs so thoroughly! I am doing a release at the moment, which is why I quickly wanted to chim in here. I will look at these docs in the coming days. As your docs can update, whichout doing a release, ill prio this after the PRs with code changes! |
Nice to know thanks! Waiting for the release and the new session pointer 👀 |
Hi @MuhammadM1998 👋 Please resolve the merge conflicts and then we can merge this! AFAIK This will also fix an issue in our changes: The backend response returns an object named |
@zoey-kaiser The conflict is fixed now. Feel free to quickly rereview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nit 😄
Amazing! Thank you so much for the changes. I think you really improved the docs for the refresh provider. I apologize for it taking longer to merge this PR, the start of the year was pretty crazy! |
Resolves #606.
This updates the
local
&refresh
providers docs to indicate that we can pass any payload to thesignIn
method, not just auser
&password
. I've also added an example and reworded some parts that I felt was not clear enough. Feel free to reedit if needed 🙏