-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
マルチ転送フィルターを設定可能にする #62
Changes from 12 commits
da028f5
e2c73d8
3bd9be8
c593ce5
8521ea0
1c5cdd8
91b1e92
45b09ef
53e1d6e
f12b9e0
b98f63f
8d09916
a181a49
ffd5c58
c0ac41c
a670136
d0394af
7ebc714
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -123,15 +123,92 @@ public class RuleList | |
{ | ||
public Rule[] data; | ||
} | ||
[System.Serializable] | ||
public class ForwardingFilter | ||
{ | ||
public bool enableAction = false; | ||
public string action; | ||
public bool enableName = false; | ||
public string name; | ||
public bool enablePriority = false; | ||
public int priority; | ||
public RuleList[] rules; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. RuleList の配列だから ruleLists の方が名前的に良さそう。rules だと Rule の配列だと思ってしまいそうなので。 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ruleLists に名前を変えます。 |
||
public bool enableVersion = false; | ||
public string version = ""; | ||
public bool enableMetadata = false; | ||
public string metadata = ""; | ||
} | ||
public static class ForwardingFilterHelper | ||
{ | ||
[Serializable] | ||
private class ForwardingFilterMetadata | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. そもそもこれって ForwardingFilter に渡すメタデータ用のクラスなので、string metadata の代わりに ForwardingFilterMetadata metadata にした方が良いです。 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
というようにした方が良いというご指摘だと理解したのですが、ここは JSON 用のプロパティのため、string にしておかないとうまくいかないようです There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. いや、ForwardingFilter クラスに定義してある string metadata を、string じゃなく ForwardingFilterMetadata にした方が良いよねって話です There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 失礼しました。勘違いしておりました。
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. インスペクタで設定してもらう値だから初期値はいらないはず |
||
{ | ||
public string metadata; | ||
} | ||
private static void ConfigureFilter(Sora.ForwardingFilter filter, ForwardingFilter settings) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. settings という名前が現状と合ってなさそう There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. forwardingFilter に修正します |
||
{ | ||
if (settings.enableAction) filter.Action = settings.action; | ||
if (settings.enableName) filter.Name = settings.name; | ||
if (settings.enablePriority) filter.Priority = settings.priority; | ||
|
||
if (settings.rules != null) | ||
{ | ||
foreach (var ruleSet in settings.rules) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ruleSet の Set は集合だと勘違いしやすいので、別の名前を付けたほうが良いです There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ruleListData にします |
||
{ | ||
if (ruleSet?.data == null) continue; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. null になることはない想定です。こちらも修正します |
||
|
||
var ruleList = new List<Sora.ForwardingFilter.Rule>(); | ||
foreach (var rule in ruleSet.data) | ||
{ | ||
var newRule = new Sora.ForwardingFilter.Rule | ||
{ | ||
Field = rule.field, | ||
Operator = rule.op | ||
}; | ||
newRule.Values.AddRange(rule.values); | ||
ruleList.Add(newRule); | ||
} | ||
|
||
if (ruleList.Any()) | ||
{ | ||
filter.Rules.Add(ruleList); | ||
} | ||
} | ||
} | ||
|
||
if (settings.enableVersion) filter.Version = settings.version; | ||
if (settings.enableMetadata) | ||
{ | ||
filter.Metadata = ForwardingFilterMetadataHelper.ConvertMetadataToJson(settings.metadata); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ここでしか ConvertMetadataToJson 関数を使ってないので、この関数に処理を分ける必要は無いです There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
} | ||
} | ||
private static class ForwardingFilterMetadataHelper | ||
{ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ToJson 1個で済むようになったので、他の if 文と同じ書き方にしておいて下さい There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ご指摘のとおりです。他とあわせて一行になるようにします。 |
||
public static string ConvertMetadataToJson(string metadata) | ||
{ | ||
var ffMetadata = new ForwardingFilterMetadata() | ||
{ | ||
metadata = metadata | ||
}; | ||
return JsonUtility.ToJson(ffMetadata); | ||
} | ||
} | ||
public static Sora.ForwardingFilter CreateFilter(ForwardingFilter settings) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Create より Convert の方が機能として近そうなのと、この機能は Forwarding Filter なので略して Filter と書いてはダメです。 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 結果的に ForwardingFilterHelper はこの関数1個しか使わないので、ForwardingFilterHelper というクラスにまとめなくても、単に SoraSample に static 関数1個生やすだけでいいと思います。 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ご指摘のとおりです。ForwardingFilterHelper にまとめるのをやめます。 |
||
{ | ||
if (settings == null) return null; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Create 関数で入力が null は前提条件として破綻してると思うので、この関数を呼び出す側がチェックした方が良いです。 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. forwardingfilter と forwardingfilters に enable フラグを追加してチェックするように修正します。 |
||
|
||
var filter = new Sora.ForwardingFilter(); | ||
ConfigureFilter(filter, settings); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. これ1箇所でしか使ってないので関数にしなくても良さそう。 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ConfigureFilter を削除して ConvertForwardingFilter にまとめます。 |
||
return filter; | ||
} | ||
} | ||
|
||
[Header("ForwardingFilter の設定")] | ||
public bool enableForwardingFilterAction = false; | ||
public string forwardingFilterAction; | ||
public RuleList[] forwardingFilter; | ||
public bool enableForwardingFilterVersion = false; | ||
public string forwardingFilterVersion = ""; | ||
public bool enableForwardingFilterMetadata = false; | ||
public string forwardingFilterMetadataMessage = ""; | ||
[System.Obsolete("forwardingFilter は非推奨です。代わりに forwardingFilters を使用してください。")] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. これはもう1行下で設定するのが正しそう?もしかしたら両方の変数に必要かも There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
public ForwardingFilter forwardingFilter; | ||
|
||
[Header("ForwardingFilters の設定")] | ||
public ForwardingFilter[] forwardingFilters; | ||
|
||
[Header("DataChannel シグナリングの設定")] | ||
public bool dataChannelSignaling = false; | ||
|
@@ -597,12 +674,6 @@ class VideoH264Params | |
public string profile_level_id; | ||
} | ||
|
||
[Serializable] | ||
class ForwardingFilterMetadata | ||
{ | ||
public string forwarding_filter_metadata; | ||
} | ||
|
||
public void OnClickStart() | ||
{ | ||
|
||
|
@@ -677,16 +748,6 @@ public void OnClickStart() | |
}; | ||
videoH264ParamsJson = JsonUtility.ToJson(h264Params); | ||
} | ||
// enableForwardingFilterMetadata が true の場合はメタデータを設定する | ||
string forwardingFilterMetadataJson = ""; | ||
if (enableForwardingFilterMetadata) | ||
{ | ||
var ffm = new ForwardingFilterMetadata() | ||
{ | ||
forwarding_filter_metadata = forwardingFilterMetadataMessage | ||
}; | ||
forwardingFilterMetadataJson = JsonUtility.ToJson(ffm); | ||
} | ||
|
||
InitSora(); | ||
|
||
|
@@ -777,30 +838,23 @@ public void OnClickStart() | |
} | ||
fixedDataChannelLabels = config.DataChannels.Select(x => x.Label).ToArray(); | ||
} | ||
if (forwardingFilter.Length != 0) | ||
if (forwardingFilter != null) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. インスペクタで設定している以上、通常 forwardingFilter は null にはならないので、bool enableForwardingFilter を用意するか、以前と同じ条件にするなら forwardingFilter.rules.Length != 0 にする必要があります。 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. enableForwardingFilter を用意します。 |
||
{ | ||
config.ForwardingFilter = new Sora.ForwardingFilter(); | ||
if (enableForwardingFilterAction) config.ForwardingFilter.Action = forwardingFilterAction; | ||
foreach (var rs in forwardingFilter) | ||
config.ForwardingFilter = ForwardingFilterHelper.CreateFilter(forwardingFilter); | ||
} | ||
if (forwardingFilters != null && forwardingFilters.Length > 0) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. インスペクタで設定している以上、通常 forwardingFilters は null にはならないはずです。 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 何も条件がないと forwardingfilters の項目を設定してしまうのでフラグを用意します。 |
||
{ | ||
config.ForwardingFilters = new List<Sora.ForwardingFilter>(); | ||
|
||
foreach (var filter in forwardingFilters) | ||
{ | ||
var ccrs = new List<Sora.ForwardingFilter.Rule>(); | ||
foreach (var r in rs.data) | ||
var newFilter = ForwardingFilterHelper.CreateFilter(filter); | ||
if (newFilter != null) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ここが null になることは無いはず There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ご指摘のとおりです。チェックを外します。 |
||
{ | ||
var ccr = new Sora.ForwardingFilter.Rule(); | ||
ccr.Field = r.field; | ||
ccr.Operator = r.op; | ||
foreach (var v in r.values) | ||
{ | ||
ccr.Values.Add(v); | ||
} | ||
ccrs.Add(ccr); | ||
config.ForwardingFilters.Add(newFilter); | ||
} | ||
config.ForwardingFilter.Rules.Add(ccrs); | ||
} | ||
if (enableForwardingFilterVersion) config.ForwardingFilter.Version = forwardingFilterVersion; | ||
if (enableForwardingFilterMetadata) config.ForwardingFilter.Metadata = forwardingFilterMetadataJson; | ||
} | ||
|
||
sora.Connect(config); | ||
SetState(State.Started); | ||
Debug.LogFormat("Sora is Created: signalingUrl={0}, channelId={1}", signalingUrl, channelId); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここ [ADD] のところと同じ内容だから削って良さそう
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
確かに同じことが書いてあるだけでした。消します。