-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
マルチ転送フィルターを設定可能にする #62
Merged
+74
−43
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
da028f5
マルチ転送フィルターを追加する
torikizi e2c73d8
変更履歴を更新
torikizi 3bd9be8
CHANGE ではなく ADD
torikizi c593ce5
転送フィルターの設定を見直し
torikizi 8521ea0
転送フィルターの処理を共通化
torikizi 1c5cdd8
さらに共通化
torikizi 91b1e92
metadata を JSON にする場所を共通にする
torikizi 45b09ef
整える
torikizi 53e1d6e
共通のヘルパークラスを作って設定時の処理をスリム化
torikizi f12b9e0
ヘルパーに全てまとめる
torikizi b98f63f
非推奨メッセージを追加
torikizi 8d09916
Settings がついている必要はなかった
torikizi a181a49
ヘルパーにまとめる必要はなかった
torikizi ffd5c58
ForwardingFilter クラスの metadata は string ではない
torikizi c0ac41c
初期値いらない
torikizi a670136
CHANGES の内容見直し
torikizi d0394af
Inspector で設定するケースの null チェックをやめる
torikizi 7ebc714
rules ではなく ruleLists に名前を変える
torikizi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これはもう1行下で設定するのが正しそう?もしかしたら両方の変数に必要かも
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
対象としては両方あった方が良さそうですね。両方設定します。