Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libwebrtc を m130.6723.2.0 にアップデート #141

Merged
merged 6 commits into from
Nov 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,14 @@
- @voluntas
- [UPDATE] Boost を 1.86.0 にあげる
- @voluntas
- [UPDATE] libwebrtc を m129.6668.1.1 にあげる
- [UPDATE] libwebrtc を m130.6723.2.0 にあげる
- H.265 Patch の修正に伴い、C++ SDK の H.265 に関する設定を変更
- examples と test に `rtc::CreateRandomString` のヘッダを追加
- `SetRtpTimestamp` を `frame.timestamp` から `frame.rtp_timestamp` に変更
- `scalable_track_source.h` と `scalable_track_source.cpp` の `absl::optional` を `std::optional` に変更
- `nvcodec_video_decoder.h` と `vpl_video_decoder.h` に `#include <optional>` を追加
- `nvcodec_video_decoder.cpp` と `vpl_video_decoder.cpp` の `absl::nullopt` を `std::nullopt` に変更
- Android の test アプリの cmake バージョンを VERSION と合わせる
- @tnoho @torikizi @melpon
- [UPDATE] Xcode のバージョンを 15.4 にあげる
- @tnoho
Expand Down
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
SORA_CPP_SDK_VERSION=2024.8.0-canary.25
WEBRTC_BUILD_VERSION=m129.6668.1.1
WEBRTC_BUILD_VERSION=m130.6723.2.0
BOOST_VERSION=1.86.0
CMAKE_VERSION=3.30.5
CUDA_VERSION=11.8.0-1
Expand Down
2 changes: 1 addition & 1 deletion examples/VERSION
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
SORA_CPP_SDK_VERSION=2024.8.0-canary.25
WEBRTC_BUILD_VERSION=m129.6668.1.1
WEBRTC_BUILD_VERSION=m130.6723.2.0
BOOST_VERSION=1.86.0
CMAKE_VERSION=3.30.5
SDL2_VERSION=2.30.8
Expand Down
2 changes: 2 additions & 0 deletions include/sora/hwenc_nvcodec/nvcodec_video_decoder.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#ifndef SORA_HWENC_NVCODEC_NVCODEC_VIDEO_DECODER_H_
#define SORA_HWENC_NVCODEC_NVCODEC_VIDEO_DECODER_H_

#include <optional>

// WebRTC
#include <api/video_codecs/video_decoder.h>
#include <common_video/include/video_frame_buffer_pool.h>
Expand Down
1 change: 1 addition & 0 deletions include/sora/hwenc_vpl/vpl_video_decoder.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#define SORA_HWENC_VPL_VPL_VIDEO_DECODER_H_

#include <memory>
#include <optional>

// WebRTC
#include <api/video/video_codec_type.h>
Expand Down
2 changes: 1 addition & 1 deletion include/sora/scalable_track_source.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class ScalableVideoTrackSource : public rtc::AdaptedVideoTrackSource {
virtual ~ScalableVideoTrackSource();

bool is_screencast() const override;
absl::optional<bool> needs_denoising() const override;
std::optional<bool> needs_denoising() const override;
webrtc::MediaSourceInterface::SourceState state() const override;
bool remote() const override;
bool OnCapturedFrame(const webrtc::VideoFrame& frame);
Expand Down
4 changes: 2 additions & 2 deletions src/hwenc_nvcodec/nvcodec_video_decoder.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@ int32_t NvCodecVideoDecoder::Decode(const webrtc::EncodedImage& input_image,
.set_video_frame_buffer(i420_buffer)
.set_timestamp_rtp(pts)
.build();
decode_complete_callback_->Decoded(decoded_image, absl::nullopt,
absl::nullopt);
decode_complete_callback_->Decoded(decoded_image, std::nullopt,
std::nullopt);

decoder_->UnlockFrame(frame);
}
Expand Down
4 changes: 2 additions & 2 deletions src/hwenc_vpl/vpl_video_decoder.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -310,8 +310,8 @@ int32_t VplVideoDecoderImpl::Decode(const webrtc::EncodedImage& input_image,
.set_video_frame_buffer(i420_buffer)
.set_timestamp_rtp(pts)
.build();
decode_complete_callback_->Decoded(decoded_image, absl::nullopt,
absl::nullopt);
decode_complete_callback_->Decoded(decoded_image, std::nullopt,
std::nullopt);
}

return WEBRTC_VIDEO_CODEC_OK;
Expand Down
2 changes: 1 addition & 1 deletion src/scalable_track_source.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ bool ScalableVideoTrackSource::is_screencast() const {
return false;
}

absl::optional<bool> ScalableVideoTrackSource::needs_denoising() const {
std::optional<bool> ScalableVideoTrackSource::needs_denoising() const {
return false;
}

Expand Down