Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libwebrtc を m130.6723.2.0 にアップデート #141

Merged
merged 6 commits into from
Nov 25, 2024

Conversation

torikizi
Copy link
Contributor

libwebrtc を m130.6723.2.0 にアップデートしました。


This pull request includes updates to various dependencies and code refactoring to replace absl::optional with std::optional. The most important changes include updating the WebRTC version, modifying header files to include <optional>, and refactoring the code to use std::optional instead of absl::optional.

Dependency updates:

  • Updated WebRTC version from m129.6668.1.1 to m130.6723.2.0 in CHANGES.md, VERSION, and examples/VERSION files. [1] [2] [3]

Code refactoring:

  • Added #include <optional> to nvcodec_video_decoder.h and vpl_video_decoder.h header files. [1] [2]
  • Changed absl::optional to std::optional in scalable_track_source.h and scalable_track_source.cpp. [1] [2]
  • Replaced absl::nullopt with std::nullopt in nvcodec_video_decoder.cpp and vpl_video_decoder.cpp. [1] [2]

@torikizi torikizi requested a review from miosakuma November 25, 2024 03:42
Copy link
Contributor

@miosakuma miosakuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

対応ありがとうございます!

@torikizi
Copy link
Contributor Author

確認ありがとうございました。こちらマージします。

@torikizi torikizi merged commit 522af47 into develop Nov 25, 2024
10 checks passed
@torikizi torikizi deleted the feature/update-webrtc-m130.6723.2.0 branch November 25, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants