Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] header #27

Merged
merged 12 commits into from
Dec 6, 2021
Merged

[MISC] header #27

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4392eed
[MISC] {seqan3->sharg}/version.hpp
eseiler Dec 3, 2021
e5e9e42
[MISC] Sort headers in include
eseiler Dec 3, 2021
6c7c570
[DOC] fix closing namespace comment
eseiler Dec 3, 2021
38d2141
[MISC] Simplify includes in test/snippet
eseiler Dec 3, 2021
4295346
[MISC] Simplify includes in test/unit
eseiler Dec 3, 2021
0f11f65
[MISC] Simplify includes in doc
eseiler Dec 3, 2021
7c13d66
[INFRA] Add header test
eseiler Dec 3, 2021
ada95db
[MISC] Add missing platform include
eseiler Dec 3, 2021
f8c4fb9
[MISC] minimize stl includes
eseiler Dec 3, 2021
ce80f17
[MISC] minimize seqan3 includes
eseiler Dec 3, 2021
622a14d
[MISC] minimize sharg includes
eseiler Dec 3, 2021
e5df0eb
[INFRA] Add header test CI
eseiler Dec 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion include/sharg/argument_parser.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include <set>

#include <seqan3/core/debug_stream/detail/to_string.hpp>
#include <seqan3/core/detail/test_accessor.hpp>

#include <sharg/detail/format_help.hpp>
#include <sharg/detail/format_html.hpp>
Expand Down
2 changes: 0 additions & 2 deletions include/sharg/auxiliary.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@
#include <seqan3/core/debug_stream/debug_stream_type.hpp>
#include <seqan3/core/detail/customisation_point.hpp>
#include <seqan3/io/stream/concept.hpp>
#include <seqan3/std/concepts>
#include <seqan3/std/type_traits>

#include <sharg/platform.hpp>

Expand Down
3 changes: 0 additions & 3 deletions include/sharg/detail/concept.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@

#include <string>

#include <seqan3/std/concepts>
#include <seqan3/std/type_traits>

#include <sharg/platform.hpp>

namespace sharg::detail
Expand Down
1 change: 1 addition & 0 deletions include/sharg/detail/format_base.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#pragma once

#include <seqan3/utility/detail/type_name_as_string.hpp>
#include <seqan3/utility/type_list/traits.hpp>

#include <sharg/auxiliary.hpp>
#include <sharg/detail/concept.hpp>
Expand Down
9 changes: 7 additions & 2 deletions include/sharg/detail/format_help.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,16 @@

#pragma once

#include <seqan3/core/detail/test_accessor.hpp>

#include <sharg/detail/format_base.hpp>
#include <sharg/detail/terminal.hpp>

namespace seqan3::detail
{

struct test_accessor;

} // seqan3::detail

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a weird change. It is just as easy to copy over the respective file and put it into the sharg namespace, then replace the include. There is an issue for this #14 :)
Can you revert this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it removes the stuff that seqan3 includes in the test_accessor header, and I already adapted #14 to replace this forward declaration.

Btw, do we really need a header? because we do this declaration exactly once.

namespace sharg::detail
{

Expand Down
1 change: 0 additions & 1 deletion include/sharg/detail/format_parse.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
#pragma once

#include <seqan3/std/charconv>
#include <seqan3/std/concepts>
#include <seqan3/utility/char_operations/predicate.hpp>

#include <sharg/detail/format_base.hpp>
Expand Down
4 changes: 0 additions & 4 deletions include/sharg/validators.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@
#include <seqan3/core/debug_stream/range.hpp>
#include <seqan3/io/detail/misc.hpp>
#include <seqan3/io/detail/safe_filesystem_entry.hpp>
#include <seqan3/std/algorithm>
#include <seqan3/std/concepts>
#include <seqan3/std/ranges>
#include <seqan3/utility/type_list/traits.hpp>
#include <seqan3/utility/views/join_with.hpp>

#include <sharg/exceptions.hpp>
Expand Down