[MISC] header #27
[MISC] header #27
Conversation
seqan3 header are in a separate block to be easily spotted
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/seqan/sharg-parser/GoxTwW5xbSNKBuxLPJkP4hueoNqc |
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
+ Coverage 94.35% 95.59% +1.24%
==========================================
Files 11 11
Lines 1080 886 -194
==========================================
- Hits 1019 847 -172
+ Misses 61 39 -22
Continue to review full report at Codecov.
|
debug_stream can be replaced with cerr
removed unnecessary includes, sorted headers
removed unnecessary includes, replaced debug_stream
|
|
||
| namespace seqan3::detail | ||
| { | ||
|
|
||
| struct test_accessor; | ||
|
|
||
| } // seqan3::detail |
There was a problem hiding this comment.
I adapted #14 to remove this declaration and replace it with the sharg include
include/sharg/detail/format_help.hpp
Outdated
| #include <seqan3/core/detail/test_accessor.hpp> | ||
|
|
||
| #include <sharg/detail/format_base.hpp> | ||
| #include <sharg/detail/terminal.hpp> | ||
|
|
||
| namespace seqan3::detail | ||
| { | ||
|
|
||
| struct test_accessor; | ||
|
|
||
| } // seqan3::detail | ||
|
|
There was a problem hiding this comment.
This is a weird change. It is just as easy to copy over the respective file and put it into the sharg namespace, then replace the include. There is an issue for this #14 :)
Can you revert this change?
There was a problem hiding this comment.
Well, it removes the stuff that seqan3 includes in the test_accessor header, and I already adapted #14 to replace this forward declaration.
Btw, do we really need a header? because we do this declaration exactly once.
Commit 1 resolves #4
Resolves #25
test/unitandtest/snippetseqan3::debug_stream->std::cerr