Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF/OPT: delay import of requests until used/needed in _etrequest #30

Merged
merged 1 commit into from
Feb 9, 2021
Merged

RF/OPT: delay import of requests until used/needed in _etrequest #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion etelemetry/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
from requests import request, ConnectionError, ReadTimeout
import os

try:
Expand All @@ -21,6 +20,9 @@ class BadVersionError(RuntimeError):


def _etrequest(endpoint, method="get", **kwargs):
# Delay requests import until actually used to at least not
# add runtime penalty of requests import whenever not needed
from requests import request, ConnectionError, ReadTimeout
if kwargs.get('timeout') is None:
kwargs['timeout'] = 5

Expand Down