RF/OPT: delay import of requests until used/needed in _etrequest #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a partial workaround for sensein#29 where ultimately requests is not a dependency at all, but rather built-in http is used for that minimal amount of interaction needed. This minimal change should shave off about 60ms from etelemetry import/use runtime whenever no refresh _etrequest is needed to be sent
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 81.15% 81.69% +0.53%
==========================================
Files 3 3
Lines 69 71 +2
==========================================
+ Hits 56 58 +2
Misses 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mgxd
approved these changes
Feb 9, 2021
|
I guess it would be up to @satra to press the big green button now ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a partial workaround for
#29
where ultimately requests is not a dependency at all, but rather built-in http
is used for that minimal amount of interaction needed.
This minimal change should shave off about 60ms from etelemetry import/use
runtime whenever no refresh _etrequest is needed to be sent