Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix fail to find crypto attribute on pc-tests #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

odudex
Copy link
Member

@odudex odudex commented Oct 9, 2023

Debugging test errors on Krux I found
module 'urtypes' has no attribute 'crypto' error would be triggered on Krux tests, ex:test_parse_wallet

if isinstance(wallet_data, UR):
        # Try to parse as a Crypto-Output type
        try:
            output = urtypes.crypto.Output.from_cbor(wallet_data.cbor)
            return Descriptor.from_string(output.descriptor()), None
        except:
            pass

It is fixed by this import on root

@codecov
Copy link

codecov bot commented Oct 9, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant